chinmoyr created this revision. chinmoyr added reviewers: hein, Plasma. chinmoyr set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY When in folder view(placed in panel) location is set to Desktop(desktop:/), clicking on a *.desktop file with Type=Link should change to the pointed directory (this is what FolderView tries to do). Now in this context FolderModel::isDir, as expected, returns true but since FolderModel::cd uses KFileItem::isDir, it evaluates to false and directory is not changed. So using IsDirRole in place of KFileItem::isDir can resolve this conflict. TEST PLAN Before Applying patch: Set location to 'desktop:/' Clicked on 'Home' Nothing happened (neither cd nor dolphin opened) After patch: Set location to desktop:/ Clicked on Home Directory changed in place and contents of home directory shown. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3927 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, hein, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
