> On Jan. 2, 2017, 9:39 p.m., David Edmundson wrote: > > I'm a bit confused by one part: > > > > kpackagetool5 --help > > tells me: > > > > -t, --type <type> The type of package, e.g. theme, wallpaper, > > plasmoid, dataengine, runner, > > layout-template, > > etc. > > > > > > you're passing it something like -t Plasma/Applet > > > > If this code is correct (and I think it is) the docs for kpackagetool5 are > > wrong.
yes, i think that was just lifted from plasmapkg2 which kpackagetool started as a fork of. so in the help of kpackagetool I should instead specify that the type must be the servicetype of the packagestructure so in the form of Plasma/Applet, KPackage/Generic, Plasma/Theme - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129753/#review101745 ----------------------------------------------------------- On Jan. 2, 2017, 7:52 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129753/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2017, 7:52 p.m.) > > > Review request for Plasma and Aleix Pol Gonzalez. > > > Bugs: 374463 > http://bugs.kde.org/show_bug.cgi?id=374463 > > > Repository: plasma-framework > > > Description > ------- > > there is a single difference between command line parameters of plasmapkg2 > and kpackagetool5: plasmapkg2 had some hardcoded names like "theme", > "plasmoid" etc. > kpackagetool5 requires the servicetype name to be passed instead. in order to > stay compatible convert those parameter with the proper servicetype name. > it's parsing parameters by hand in order to just pass anything else without > further parsing > > > Diffs > ----- > > src/plasma/packagestructure/plasmathemepackage.cpp 94f0c5c > src/plasmapkg/main.cpp b61b2e5 > > Diff: https://git.reviewboard.kde.org/r/129753/diff/ > > > Testing > ------- > > installing themes from knewstuff works again > > > Thanks, > > Marco Martin > >
