subdiff accepted this revision. subdiff added a reviewer: subdiff. subdiff added a comment. This revision is now accepted and ready to land.
Just a nitpick: Since you have `realHeight` as the first argument, maybe also define it as first. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3885 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, #plasma, subdiff Cc: subdiff, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas