----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129704/#review101738 -----------------------------------------------------------
unfortunately this has a significant problem: see https://bugs.kde.org/show_bug.cgi?id=374463 the problem is that plasmapkg2 had several hardcoded things for type names different from their corresponding servicetype, for instance "theme" instead of "Plasma/Theme" "plasmoid" instead of "Plasma/Applet" etc. knsrcfiles around were using those names, for instance for plasma theme, InstallationCommand=plasmapkg2 -t theme -i %f this wrapper should convert those parameters to keep compatibility (we can port stuff in workspace using plasmapkg2, but retrocompatibility is needed for old workspace new frameworks) - Marco Martin On Dec. 27, 2016, 6:12 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129704/ > ----------------------------------------------------------- > > (Updated Dec. 27, 2016, 6:12 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > They're supposed to do the same, completely different codebases. Also some > things had to be ported. > > I'd recommend everything to be ported to use kpackagetool (knsrc files!) but > still it's better to at least make sure we stick to one set of features. > > > Diffs > ----- > > src/plasmapkg/CMakeLists.txt 7d3df5d22 > src/plasmapkg/main.cpp dfbd2f4c3 > src/plasmapkg/plasmapkg.h 3383980db > src/plasmapkg/plasmapkg.cpp 3724ae85e > > Diff: https://git.reviewboard.kde.org/r/129704/diff/ > > > Testing > ------- > > `plasmapkg2 --help` returns `kpackagetool5`'s. > > > Thanks, > > Aleix Pol Gonzalez > >
