anthonyfieroni added inline comments.

INLINE COMMENTS

> iconapplet.cpp:235
> +        m_openWithActions.clear();
> +        delete m_openContainingFolderAction;
> +    }

Make it smart pointer or assign nullptr after deletion or you hit a crash below

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3905

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: anthonyfieroni, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Reply via email to