apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
I disagree that it's a big dependency chain, I agree that the feature is
quite small, it's just appstream, but ok.
INLINE COMMENTS
> appentry.cpp:146
> {
> +#ifdef APPSTREAMQT
> static AppStream::Pool pool;
I would prefer to ifdef out the whole function and not call it...
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3923
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
