[KDE Bugtracking System] REMINDER: current Plasma regressions

2013-01-07 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma. This is a weekly reminder. This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 202336: https://bugs.kde.org/show_bug.cgi?id=202336 Priority: NOR Severity: normal Platform: Gentoo

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 8, 2013, 12:21 a.m.) Review request for kde-workspace, kwin,

Re: Review Request: use Plasma::Dialog for kmix osd

2013-01-07 Thread Kai Uwe Broulik
> On Jan. 7, 2013, 9:35 p.m., Kai Uwe Broulik wrote: > > What about KDE/4.10 branch? Ok, you merged. Never mind :-) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#revie

Re: Review Request: use Plasma::Dialog for kmix osd

2013-01-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#review24946 --- What about KDE/4.10 branch? - Kai Uwe Broulik On Jan. 6, 201

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-07 Thread Aaron J. Seigo
> On Jan. 7, 2013, 4:49 p.m., Xuetian Weng wrote: > > And I don't really think Plasma::Dialog is suitable here. Plasma::Dialog > > use hardcoded dialogs/background svg path internally, which should be > > tooltips. And paintEvent is duplicated, you don't really use Plasma::Dialog > > paintEven

Re: Review Request: Rename krunner plugin konsolesessions to konsoleprofiles

2013-01-07 Thread Aaron J. Seigo
> On Jan. 7, 2013, 10:49 a.m., Aaron J. Seigo wrote: > > i can understand changing the visible name, but why change the plugin name > > and the rest of it? that's an implementation detail, and while the name > > used may be technically "wrong" it is both a smaller change as well as a > > safer

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 7, 2013, 7:01 p.m.) Review request for kde-workspace, kwin,

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24933 --- kwin/tabbox/qml/ShadowedSvgItem.qml

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 7, 2013, 5:49 p.m.) Review request for kde-workspace, kwin,

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Martin Gräßlin
> On Jan. 7, 2013, 4:39 p.m., Martin Gräßlin wrote: > > kwin/tabbox/qml/qmldir, line 2 > > > > > > please don't include the IconTabBox in the qmldir. I consider it > > private API :-) > > Xuetian Weng wrote: >

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/#review24926 --- And I don't really think Plasma::Dialog is suitable here. Plasm

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
> On Jan. 7, 2013, 4:39 p.m., Martin Gräßlin wrote: > > kwin/tabbox/qml/qmldir, line 2 > > > > > > please don't include the IconTabBox in the qmldir. I consider it > > private API :-) I saw IconTabBox is used twic

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24924 --- I need to think about whether I want to have it in org.kde.kwin

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 7, 2013, 4:07 p.m.) Review request for kde-workspace, kwin,

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24920 --- Approach seems fine to me (though I haven't tested it yet). I'm

Re: KDEREVIEW: share like connect and plasmate

2013-01-07 Thread Marco Martin
On Monday 07 January 2013, Marco Martin wrote: > On Sunday 06 January 2013, Aaron J. Seigo wrote: > > On Sunday, January 6, 2013 18:27:48 David Edmundson wrote: > > > I noticed the API of providelib is still completely undocumented. As a > > > > agreed. and until it is documented, i don't expect a

Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Sei

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/#review24918 --- applets/icontasks/tooltips/tooltip.cpp

Re: Review Request: Rename krunner plugin konsolesessions to konsoleprofiles

2013-01-07 Thread Jekyll Wu
> On Jan. 7, 2013, 10:49 a.m., Aaron J. Seigo wrote: > > i can understand changing the visible name, but why change the plugin name > > and the rest of it? that's an implementation detail, and while the name > > used may be technically "wrong" it is both a smaller change as well as a > > safer

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24913 --- This review has been submitted with commit d2cd9b46c506063fbd1

Re: Review Request: use Plasma::Dialog for kmix osd

2013-01-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#review24912 --- This review has been submitted with commit 0e9d369c573a56af94b

Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-07 Thread Cedric Bellegarde
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/ --- Review request for Plasma and Aaron J. Seigo. Description --- Similia

Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Aaron J. Seigo
On Monday, January 7, 2013 07:43:22 Weng Xuetian wrote: > Well.. since my mail to kcd is still being moderated I guess I'd also post > this patch here. looks nice and straighforward. huzzah. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. __

Re: Review Request: Fix bug 289427 - plasma-desktop freezes when selecting fixed-size fonts in the clock widget

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108102/#review24910 --- Ship it! looks good. plasma/generic/applets/digital-clock/cl

Re: Review Request: Fix dismissing LastNotificationPopup often failing

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107908/#review24909 --- the problem is in Qt, but this looks fine to me. +1 from me, bu

Re: Review Request: Expose default Plasma theme to QML based KSplash

2013-01-07 Thread Aaron J. Seigo
> On Jan. 7, 2013, 10:59 a.m., Aaron J. Seigo wrote: > > wouldn't it make more sense to simply use the Theme QML element from > > PlasmaCore components? > > Marco Martin wrote: > yes, either that or if org.kde.plasma.core is imported, a global "theme" > element is already registered, so th

Re: Review Request: Keep placeholder text visible when empty and focused

2013-01-07 Thread Aaron J. Seigo
> On Dec. 13, 2012, 4:32 p.m., Aaron J. Seigo wrote: > > as this is indeed a rather widely shifting style (far beyond KDE), as long > > as it is consistent with kdelibs and Qt i'm ok with this. and consistency > > is the hard bit. yes, there is 107678 for kdelibs (which is half the > > battle)

Re: KDEREVIEW: share like connect and plasmate

2013-01-07 Thread Marco Martin
On Sunday 06 January 2013, Aaron J. Seigo wrote: > On Sunday, January 6, 2013 18:27:48 David Edmundson wrote: > > I noticed the API of providelib is still completely undocumented. As a > > agreed. and until it is documented, i don't expect anyone to reasonably > write plugins for it. documentation

Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Thomas Lübking
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote: > > I don't like having a link dependency on plasmagenericshell. If that is > > supposed to be used, then it needs to go to the workspaces libs. > > > > I also think that this approach just doesn't scale. We use Plasma styled > > dialogs for

Re: Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Weng Xuetian
Well.. since my mail to kcd is still being moderated I guess I'd also post this patch here. RFC: QML shadow patch, and handle mask correctly. Screen shot. http://wstaw.org/m/2013/01/07/plasma-desktopoj1171.png The non-composite side is not affected as far as I tested. Shadow will not be shown if

Re: Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Martin Gräßlin
On Monday 07 January 2013 12:51:47 Marco Martin wrote: > On Monday 07 January 2013, Martin Gräßlin wrote: > > > if that's so, then all that needs be done is to add the shadows by > > > name in the rendering in the tabbox. shadow-top, etc. this can be > > > done easily in the QML itself,

Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Marco Martin
On Monday 07 January 2013, Martin Gräßlin wrote: > > if that's so, then all that needs be done is to add the shadows by > > name in the rendering in the tabbox. shadow-top, etc. this can be > > done easily in the QML itself, and the problem would be solved. > > erm how? > > Plasm

Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Martin Gräßlin
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote: > > I don't like having a link dependency on plasmagenericshell. If that is > > supposed to be used, then it needs to go to the workspaces libs. > > > > I also think that this approach just doesn't scale. We use Plasma styled > > dialogs for

Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Aaron J. Seigo
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote: > > I don't like having a link dependency on plasmagenericshell. If that is > > supposed to be used, then it needs to go to the workspaces libs. > > > > I also think that this approach just doesn't scale. We use Plasma styled > > dialogs for

Re: Review Request: Expose default Plasma theme to QML based KSplash

2013-01-07 Thread Marco Martin
> On Jan. 7, 2013, 10:59 a.m., Aaron J. Seigo wrote: > > wouldn't it make more sense to simply use the Theme QML element from > > PlasmaCore components? yes, either that or if org.kde.plasma.core is imported, a global "theme" element is already registered, so there isn't even risk of instancia

Re: Shadow bug in appmenu bar

2013-01-07 Thread Cedric Bellegarde
Le lundi 7 janvier 2013 11:50:43 Marco Martin a écrit : > any ways, i think the problem is that the top border shadow should be > removed (from the screenshot various corner shadows seem to overlap), if a > Plasma::Dialog is used, this will be done automatically, otherwise look at > the code in kd

Re: Review Request: Expose default Plasma theme to QML based KSplash

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105761/#review24888 --- wouldn't it make more sense to simply use the Theme QML element

Re: Review Request: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107868/#review24886 --- how about instead of having 2 plugins, just add sessions suppor

Re: Review Request: Move IconItem into MouseArea

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107886/#review24885 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 23, 2012, 7:25 p

Re: Shadow bug in appmenu bar

2013-01-07 Thread Marco Martin
On Monday 07 January 2013, Cedric Bellegarde wrote: > Hello, > > reading recents discussions on kde lists, i noticed that appmenu menubar > didn't have a shadow... > > I tried to add a shadow looking at krunner/panel code, it's working but > i've got a strange visual black line (see screenshot).

Re: Review Request: Rename krunner plugin konsolesessions to konsoleprofiles

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107881/#review24884 --- i can understand changing the visible name, but why change the

Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Martin Gräßlin
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote: > > I don't like having a link dependency on plasmagenericshell. If that is > > supposed to be used, then it needs to go to the workspaces libs. > > > > I also think that this approach just doesn't scale. We use Plasma styled > > dialogs for

Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108115/#review24882 --- i didn't see this review before i went in and just fixed it. th

Shadow bug in appmenu bar

2013-01-07 Thread Cedric Bellegarde
Hello, reading recents discussions on kde lists, i noticed that appmenu menubar didn't have a shadow... I tried to add a shadow looking at krunner/panel code, it's working but i've got a strange visual black line (see screenshot). http://quickgit.kde.org/?p=kde- workspace.git&a=commitdiff&h=d

Re: Review Request: Translate \n into for error messages

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108123/#review24881 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 3, 2013, 3:33 p.

Re: Review Request: port branchdialog to KInputDialog

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108125/#review24879 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 3, 2013, 3:52 p.

Re: Review Request: port internal pointer to data query

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108126/#review24878 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 3, 2013, 3:53 p.

Re: Review Request: support svg and svgz files in imageloader

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108127/#review24877 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 3, 2013, 3:54 p.

Re: Review Request: port from radioButton*Checked to radioButtonChecked

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108128/#review24876 --- plasmate/mainwindow.cpp

Re: Review Request: move away the git related stuff from Timeline::loadTimeLine

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108129/#review24875 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 3, 2013, 3:57 p.

Re: Review Request: Plasmate: Display an error message when signingwidget is failing to generate a new key

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108205/#review24874 --- plasmate/publisher/signingwidget.cpp

Re: Review Request: Plasmate: Remove PasswordAsker class

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108207/#review24873 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 5, 2013, 5:46 p.

Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Aaron J. Seigo
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote: > > I don't like having a link dependency on plasmagenericshell. If that is > > supposed to be used, then it needs to go to the workspaces libs. > > > > I also think that this approach just doesn't scale. We use Plasma styled > > dialogs for

Re: KDEREVIEW: share like connect and plasmate

2013-01-07 Thread Aaron J. Seigo
On Monday, January 7, 2013 22:58:12 Ben Cooksley wrote: > On Sun, Jan 6, 2013 at 2:10 PM, Aaron J. Seigo wrote: > > On Thursday, January 3, 2013 09:56:47 Ben Cooksley wrote: > >> What about Share-Like-Connect? > > > > i was waiting until i was back in the office with time to work on it again > >

Re: Review Request: use Plasma::Dialog for kmix osd

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#review24871 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 6, 2013, 11:52 p

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24870 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 6, 2013, 11:53 p

Re: KDEREVIEW: share like connect and plasmate

2013-01-07 Thread Ben Cooksley
On Sun, Jan 6, 2013 at 2:10 PM, Aaron J. Seigo wrote: > On Thursday, January 3, 2013 09:56:47 Ben Cooksley wrote: >> What about Share-Like-Connect? > > i was waiting until i was back in the office with time to work on it again > before requesting the move. :) > > so ... yes, SLC is ready to be mov