----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108128/#review24876 -----------------------------------------------------------
plasmate/mainwindow.cpp <http://git.reviewboard.kde.org/r/108128/#comment19100> it is still reading "radioButtonJsChecked" (note the "JS"), while later it writes to "radioButtonChecked". so the "Js" in the key name should be removed :) plasmate/startpage.cpp <http://git.reviewboard.kde.org/r/108128/#comment19101> if the radio buttons are in an exclusive group, all this setting false is not necessary -> just set the correct one to checked and the others should all turn off automatically. - Aaron J. Seigo On Jan. 3, 2013, 3:56 p.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108128/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 3:56 p.m.) > > > Review request for Plasma. > > > Description > ------- > > port from radioButton*Checked to radioButtonChecked > > > Diffs > ----- > > plasmate/mainwindow.cpp c703aaf > plasmate/startpage.cpp d649334 > > Diff: http://git.reviewboard.kde.org/r/108128/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
