> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote:
> > I don't like having a link dependency on plasmagenericshell. If that is
> > supposed to be used, then it needs to go to the workspaces libs.
> >
> > I also think that this approach just doesn't scale. We use Plasma styled
> > dialogs for more things and I don't want to have to use this approach
> > everywhere and not all of them are C++ based. Furthermore in case of KWin
> > it's a little bit stupid to set an X11 property for the shadows on a KWin
> > internal window.
> >
> > I will look into the whole thing. I think especially the tabbox has some
> > old code still around which might not be needed any more.
>
> Xuetian Weng wrote:
> yep, I totally agree what you said. But as I exam the code I couldn't
> think of any easier solution that can avoid rewrite this part of code.
> One of the problem is, the background is defined in qml, so set shadow
> here isn't correct if someone don't use a plasma background. But maybe the
> background should be move out, but in that case it would break existing
> tabbox qml (fortunately there aren't much on kde-look.org).
>
> The right approach is to use Plasma::Dialog IMHO, but use it here is not
> very easy and it would still use same code (which is in kdelibs) to set X11
> property for shadow.
>
> So kwin will directly use Plasma::Svg for tabbox shadow?.. I can't see a
> clear way for doing this right so I just take a easiest way for this. (And to
> call attention for right people on this, on purpose :P)
>
> Thomas Lübking wrote:
> KWin needs a (tmp proprietary) property to set the shadow from qml.
>
> Item {
> shadowLeft = <someimage>
> }
>
> Plasma (components) hopefully provides a qml way to access the pixmap(id)
> of a Plasma::Svg directly, otherwise one will have to create
> PlasmaCore.SvgItem (i hope they exist) and pass them over to the property
> (but i've atm. no idea how to make an image out of that)
>
> Martin Gräßlin wrote:
> given that KWin includes one layout for Plasma Active which does not set
> a background at all and which should not get a shadow, anything which would
> enforce the usage of Shadows is wrong.
>
> It needs to be done in a way as Thomas suggests. If that's not possible
> than we have to live with a regression.
"I don't like having a link dependency on plasmagenericshell. If that is
supposed to be used, then it needs to go to the workspaces libs"
libplasmagenerichsell is in kde-workspace/libs/plasmagenericshell. it obviously
has no dependency on any plasma application or shell since it's in
kde-workspace/libs. what more do you want?
"We use Plasma styled dialogs for more things and I don't want to have to use
this approach everywhere and not all of them are C++ based."
if instead of using plasma style dialogs, the code used Plasma::Dialog then it
wouldn't be an issue. if there is some reason Plasma::Dialog can not be used,
we can perhaps look at why and see if that can be fixed.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108224/#review24788
-----------------------------------------------------------
On Jan. 6, 2013, 6:55 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108224/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2013, 6:55 a.m.)
>
>
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
>
>
> Description
> -------
>
> use the same technique for krunner and some plasma to brought back tabbox
> shadow.
>
>
> Diffs
> -----
>
> kwin/CMakeLists.txt 62e9964
> kwin/kcmkwin/kwintabbox/CMakeLists.txt 72a6b72
> kwin/tabbox/declarative.h e36e67b
> kwin/tabbox/declarative.cpp 3bdcfac
> powerdevil/daemon/brightnessosdwidget.h ef08903
> powerdevil/daemon/brightnessosdwidget.cpp e4cf80a
>
> Diff: http://git.reviewboard.kde.org/r/108224/diff/
>
>
> Testing
> -------
>
> compiles, no problem.
>
>
> Thanks,
>
> Xuetian Weng
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
