-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108241/#review24926
-----------------------------------------------------------
And I don't really think Plasma::Dialog is suitable here. Plasma::Dialog use
hardcoded dialogs/background svg path internally, which should be tooltips. And
paintEvent is duplicated, you don't really use Plasma::Dialog paintEvent. I
think you should copy kdelibs/plasma/private/dialogshadows.{h,cpp} here, and
check how kdelibs handle use this, instead of use Plasma::Dialog here.
- Xuetian Weng
On Jan. 7, 2013, 1:53 p.m., Cedric Bellegarde wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108241/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2013, 1:53 p.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the
> shadow problem for icontasks tooltips
>
>
> Diffs
> -----
>
> applets/icontasks/tooltips/tooltip.cpp 43f09ed
> applets/icontasks/tooltips/tooltip_p.h 2b8ad0c
>
> Diff: http://git.reviewboard.kde.org/r/108241/diff/
>
>
> Testing
> -------
>
> localily tested, no problem
>
>
> Thanks,
>
> Cedric Bellegarde
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
