> On Jan. 7, 2013, 4:49 p.m., Xuetian Weng wrote:
> > And I don't really think Plasma::Dialog is suitable here. Plasma::Dialog
> > use hardcoded dialogs/background svg path internally, which should be
> > tooltips. And paintEvent is duplicated, you don't really use Plasma::Dialog
> > paintEvent. I think you should copy
> > kdelibs/plasma/private/dialogshadows.{h,cpp} here, and check how kdelibs
> > handle use this, instead of use Plasma::Dialog here.
paintEvent doesn't matter, but the Dialog does indeed use the
dialogs/background.svg and that is important as Xuetian has pointed out. so
yes, some sort of duplication will be necessary to fix this in the near-term. :/
the proper long term solution is to make it use Plasma::Tooltip. no excuses. no
"but i want it to ..." BS.
when i have suggested in the past to not have custom tooltips but extend the
libplasma ones until they do what is needed and then use those, people have
just done their own thing anyways. if they had listened this problem would
never have existed. it pisses me off to no end that we end up with such
problems just because people think they know better and ignore good advice.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108241/#review24926
-----------------------------------------------------------
On Jan. 7, 2013, 1:53 p.m., Cedric Bellegarde wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108241/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2013, 1:53 p.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the
> shadow problem for icontasks tooltips
>
>
> Diffs
> -----
>
> applets/icontasks/tooltips/tooltip.cpp 43f09ed
> applets/icontasks/tooltips/tooltip_p.h 2b8ad0c
>
> Diff: http://git.reviewboard.kde.org/r/108241/diff/
>
>
> Testing
> -------
>
> localily tested, no problem
>
>
> Thanks,
>
> Cedric Bellegarde
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
