----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107908/#review24909 -----------------------------------------------------------
the problem is in Qt, but this looks fine to me. +1 from me, but marco should also give it a thumbs-up before committing. - Aaron J. Seigo On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107908/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2012, 2:43 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > This patch disables the setCustomNotification while a button (close, next, > back) is pressed, to prevent popup re-shifting which seems to eat the clicked > event. > Problem is more deep in Plasma but has been around since Plasma exists, so > this should fix it for the notifications. > > > This addresses bug 311413. > http://bugs.kde.org/show_bug.cgi?id=311413 > > > Diffs > ----- > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml > e63526b > > Diff: http://git.reviewboard.kde.org/r/107908/diff/ > > > Testing > ------- > > kdialog --passivepopup "bla" > click, closes. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
