carterkozak commented on a change in pull request #273: LOG4J2-2606:
Substantially improve async logging performance under heavy load
URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r287164125
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/as
dpsenner commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287297842
##
File path: src/Appender/FileAppender.cs
##
@@ -846,11 +851
dpsenner commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287297240
##
File path: src/Appender/FileAppender.cs
##
@@ -876,6 +886,
dpsenner commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287299966
##
File path: src/Appender/FileAppender.cs
##
@@ -876,6 +886,
dpsenner commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287298895
##
File path: src/Appender/RollingFileAppender.cs
##
@@ -1147
dpsenner commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287297699
##
File path: src/Appender/RollingFileAppender.cs
##
@@ -1695
dpsenner commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287301157
##
File path: src/Appender/FileAppender.cs
##
@@ -876,6 +886,
dpsenner commented on issue #49: Fixes LOG4NET-630 Log4Net missing Timestamp
etc. in internal LogLog
URL: https://github.com/apache/logging-log4net/pull/49#issuecomment-495571413
Having two rather unrelated contributions in one pull request is odd. I
would prefer these to be two pull reque
mirec75 commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287682863
##
File path: src/Appender/FileAppender.cs
##
@@ -876,6 +886,5
mirec75 commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287704878
##
File path: src/Appender/RollingFileAppender.cs
##
@@ -1695,
dpsenner commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287725076
##
File path: src/Appender/RollingFileAppender.cs
##
@@ -1695
dpsenner commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287727243
##
File path: src/Appender/FileAppender.cs
##
@@ -876,6 +886,
mirec75 commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287704878
##
File path: src/Appender/RollingFileAppender.cs
##
@@ -1695,
mirec75 commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287740561
##
File path: src/Appender/FileAppender.cs
##
@@ -846,11 +851,
mirec75 commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287816110
##
File path: src/Appender/RollingFileAppender.cs
##
@@ -1695,
mirec75 commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287837749
##
File path: src/Appender/RollingFileAppender.cs
##
@@ -1147,
andrei-ivanov merged pull request #20: LOG4J2-2579
URL: https://github.com/apache/logging-log4j-audit/pull/20
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
mirec75 commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287844365
##
File path: src/Appender/FileAppender.cs
##
@@ -876,6 +886,5
mirec75 commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287844365
##
File path: src/Appender/FileAppender.cs
##
@@ -876,6 +886,5
mirec75 commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287844625
##
File path: src/Appender/FileAppender.cs
##
@@ -876,6 +886,5
dpsenner commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287853544
##
File path: src/Appender/RollingFileAppender.cs
##
@@ -1147
dpsenner commented on a change in pull request #48: Fixes LOG4NET-587 Mutex ~
UnauthorizedAccessException Access to the path is denied
URL: https://github.com/apache/logging-log4net/pull/48#discussion_r287857098
##
File path: src/Appender/FileAppender.cs
##
@@ -876,6 +886,
mirec75 commented on issue #49: Fixes LOG4NET-630 Log4Net missing Timestamp
etc. in internal LogLog
URL: https://github.com/apache/logging-log4net/pull/49#issuecomment-496320095
Hi Dominik, with adding the %message to the pattern I was torn between
adding it directly and between not, becau
dpsenner commented on issue #49: Fixes LOG4NET-630 Log4Net missing Timestamp
etc. in internal LogLog
URL: https://github.com/apache/logging-log4net/pull/49#issuecomment-496420190
> Do you think I shall use the `LoggingEvent` and the whole Layout Patterns
for formatting somehow?
As f
dpsenner commented on issue #49: Fixes LOG4NET-630 Log4Net missing Timestamp
etc. in internal LogLog
URL: https://github.com/apache/logging-log4net/pull/49#issuecomment-496421159
Given your substantial contribution, I see it necessary that you sign an
[individual contributor license
agree
mirec75 commented on issue #49: Fixes LOG4NET-630 Log4Net missing Timestamp
etc. in internal LogLog
URL: https://github.com/apache/logging-log4net/pull/49#issuecomment-496911894
Phew! Because of the %message, etc., I had a deeper look under the log4net
hood, how the `PatternLayout` coopera
mirec75 edited a comment on issue #49: Fixes LOG4NET-630 Log4Net missing
Timestamp etc. in internal LogLog
URL: https://github.com/apache/logging-log4net/pull/49#issuecomment-496911894
Phew! Because of the %message, etc., I had a deeper look under the log4net
hood, how the `PatternLayout`
andrei-ivanov closed pull request #16: LOG4J2-2579
URL: https://github.com/apache/logging-log4j-audit/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
andrei-ivanov closed pull request #15: LOG4J2-2551: normalize event name when
creating the AuditMessage
URL: https://github.com/apache/logging-log4j-audit/pull/15
This is an automated message from the Apache Git Service.
To
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-497964175
I seems like a better solution would be to just set the creation time
attribute for the file when it is created. I am investigating doin
JCgH4164838Gh792C124B5 commented on issue #271: Proposed fix for LOG4J2-2610
rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-497983598
I tried to find a (non-JNI) mechanism to set the creationTime when a file is
created in Java but didn't have any luck.
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-497984927
I've already written the code Files.setAttribute() should do the trick.
However, I first want to recreate the problem in my Windows VM w
JCgH4164838Gh792C124B5 commented on issue #271: Proposed fix for LOG4J2-2610
rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-498046100
Hello @rgoers (**apologies in advance for the long response**).
The **short answer** is _none of the existing tes
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-498061551
I modified RollingAppenderTimeAndSizeTest and was able to detect the problem
on Windows. I was then able to verify that my fix worked. I
fnasimbd opened a new pull request #50: Fixes LOG4NET-620 RollingFileAppender
extension that backs up only a last specified period (days, hours, etc.)
proposal
URL: https://github.com/apache/logging-log4net/pull/50
This pull request attempts implementing the feature requested in
[LOG4NET-
jvz opened a new pull request #274: [LOG4J2-2600] Add declarative Groovy
configuration DSL
URL: https://github.com/apache/logging-log4j2/pull/274
See https://issues.apache.org/jira/browse/LOG4J2-2600
This is currently a draft PR as it doesn't even seem to work properly at the
moment
JCgH4164838Gh792C124B5 commented on issue #271: Proposed fix for LOG4J2-2610
rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-498075200
Hello @rgoers .
I updated to the latest release-2.x and re-ran the regression. Your change
and updated unit tes
mirec75 commented on issue #49: Fixes LOG4NET-630 Log4Net missing Timestamp
etc. in internal LogLog
URL: https://github.com/apache/logging-log4net/pull/49#issuecomment-499698740
> Given your substantial contribution, I see it necessary that you sign an
[individual contributor license
agre
rgoers opened a new pull request #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275
Moves plugin support to its own module. Generates a Java file for recording
plugins instead of Log4jPlugins.dat. Maintains support for Plugins generated in
Log4j 2 2.x.
-
remkop commented on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500671754
I took a look. Many files changed but vast majority is import changes.
Files of interest:
M
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plug
rgoers commented on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500676166
See
https://github.com/apache/logging-log4j2/blob/LOG4J2-2621/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/processor/PluginProcessor.java
method writeC
rgoers edited a comment on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500676166
See
https://github.com/apache/logging-log4j2/blob/LOG4J2-2621/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/processor/PluginProcessor.java
method
rgoers commented on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500677053
It just occurred to me that I haven't yet updated the documentation. I will
have to do that before merging.
---
remkop commented on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500677740
OK thanks. I was looking at this with a view to in the future add another
visitor that generates an additional file for the plugins (see
https://issues.apache.org/jira
rgoers edited a comment on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500676166
See
https://github.com/apache/logging-log4j2/blob/LOG4J2-2621/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/processor/PluginProcessor.java
method
rgoers commented on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500678405
The modifications necessary for LOG4J2-2604 don't conflict at all with these
changes. It would do something similar to what writeServiceFile does, although
writing the
rgoers edited a comment on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500678405
The modifications necessary for LOG4J2-2604 don't conflict at all with these
changes. It would do something similar to what writeServiceFile does, although
writ
rgoers commented on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500685968
OK. I thought about it. Services implemented with ServiceLoader are only
loaded once. That would mean only a single instance of a Layout or Filter could
be created. Th
remkop commented on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500691086
About the shading issue, how do these changes improve things?
This is an automated message from the Apa
rgoers commented on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500710403
Presumably shading should provide support for ServiceLoader since it is
standard java. We already use it to load Log4J core. The only difficulty will
be for people who
remkop commented on issue #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500713765
(Taking another look at
[PluginProcessor](https://github.com/apache/logging-log4j2/blob/LOG4J2-2621/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/process
martin-g opened a new pull request #276: Update SLF4J to 1.7.26
URL: https://github.com/apache/logging-log4j2/pull/276
1.7.26 has been released at Feb 16th 2019.
This is an automated message from the Apache Git Service.
To res
jvz commented on a change in pull request #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275#discussion_r293570398
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/selector/ContextSelector.java
##
@@ -26,6 +27,36 @@
*/
public i
kabilanvk opened a new pull request #51: Added support for .Net Standard 2.0
URL: https://github.com/apache/logging-log4net/pull/51
LOG4NET-572: Add target for netstandard-2.0
This is an automated message from the Apac
rgoers merged pull request #275: Log4 j2 2621
URL: https://github.com/apache/logging-log4j2/pull/275
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502474319
I ran RollingAppenderSizeWithTimeTest in my Windows VM the other day and it
failed. I am trying to diagnose the problem today and have r
carterkozak commented on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502475511
@rgoers I've been able to get the test to fail locally with this: #277
That said there could be something odd going on with the
carterkozak opened a new pull request #277: Suite to reproduce LOG4J2-2613 test
flakes
URL: https://github.com/apache/logging-log4j2/pull/277
This is an automated message from the Apache Git Service.
To respond to the messag
carterkozak opened a new pull request #278: LOG4J2-2631: RoutingAppender
IdlePolicy implementations don't remove …
URL: https://github.com/apache/logging-log4j2/pull/278
…referenced appenders
Note that this makes a behavior change to RoutingAppender.getAppenders
where Routes based
carterkozak commented on a change in pull request #278: LOG4J2-2631:
RoutingAppender PurgePolicy implementations don't remove …
URL: https://github.com/apache/logging-log4j2/pull/278#discussion_r294096681
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender
carterkozak commented on a change in pull request #278: LOG4J2-2631:
RoutingAppender PurgePolicy implementations don't remove …
URL: https://github.com/apache/logging-log4j2/pull/278#discussion_r294096817
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender
carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async
logging performance under heavy load
URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-502480491
Friendly ping on this. Not a rush, just want to make sure we don't forget
about it for 2.12.0 :-)
carterkozak opened a new pull request #279: LOG4J2-2629: Avoid losing log
events when the PurgePolicy races a log event
URL: https://github.com/apache/logging-log4j2/pull/279
Stacked on top of #278
This is an automated messag
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502486266
@carterkozak Even with the Suite I still cannot get it to fail.
Can you apply the attached diff and see if it fails for you? If it
rgoers merged pull request #256: (doc) Clarify Default Rollover Strategy
URL: https://github.com/apache/logging-log4j2/pull/256
This is an automated message from the Apache Git Service.
To respond to the message, please log o
rgoers merged pull request #246: [LOG4J2-2523] adding support for request
related lookup web module
URL: https://github.com/apache/logging-log4j2/pull/246
This is an automated message from the Apache Git Service.
To respon
carterkozak commented on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502491851
I think we have a subtle race somewhere, when I keep
`statusLogger.registerListener(this);` commented I can reproduce failures, bu
carterkozak commented on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502492251
If I set the status logger level to trace and don't register the listener, I
don't see anything helpful in the log surrounding fai
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502496843
Yes, I am pretty sure this is timing related. I just don't know if it is
something in the test or something in the code.
If you
rgoers commented on issue #279: LOG4J2-2629: Avoid losing log events when the
PurgePolicy races a log event
URL: https://github.com/apache/logging-log4j2/pull/279#issuecomment-502497316
You will also have to apply this to release-2.x. As far as I am concerned
you don't need another PR - ju
carterkozak commented on issue #279: LOG4J2-2629: Avoid losing log events when
the PurgePolicy races a log event
URL: https://github.com/apache/logging-log4j2/pull/279#issuecomment-502498413
Done, thanks for the quick review @rgoers!
carterkozak merged pull request #278: LOG4J2-2631: RoutingAppender PurgePolicy
implementations don't remove …
URL: https://github.com/apache/logging-log4j2/pull/278
This is an automated message from the Apache Git Service.
T
carterkozak merged pull request #279: LOG4J2-2629: Avoid losing log events when
the PurgePolicy races a log event
URL: https://github.com/apache/logging-log4j2/pull/279
This is an automated message from the Apache Git Servic
carterkozak commented on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502499719
You're right, I set the status logger level too early and failed to record
anything while the test was running.
I was not able
carterkozak commented on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502499969
Ah, ran several more iterations and got a failure with trace enabled:
https://gist.github.com/carterkozak/c6a3bc6cfc258744bb5feb8a
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502503385
Thanks. That is perfect and is exactly what I expected. From the log we see
`2019-06-16 20:39:01,573 main DEBUG RollingFileManager ex
rgoers edited a comment on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502503385
Thanks. That is perfect and is exactly what I expected. From the log we see
```
2019-06-16 20:39:01,573 main DEBUG Rolling
rgoers edited a comment on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502503385
Thanks. That is perfect and is exactly what I expected. From the log we see
```
2019-06-16 20:39:01,573 main DEBUG Rolling
remkop commented on issue #273: LOG4J2-2606: Substantially improve async
logging performance under heavy load
URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-502506715
Thanks for the reminder!
I thought a synchronized block would express the intentions better beca
carterkozak commented on issue #273: LOG4J2-2606: Substantially improve async
logging performance under heavy load
URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-502508705
Thanks @remkop! I don't have a use case where the semaphore would be better
than a synchronized b
rgoers commented on a change in pull request #145: fix bug LOG4J2-2211
URL: https://github.com/apache/logging-log4j2/pull/145#discussion_r200211890
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -973,7 +973,8 @@ priva
rgoers commented on issue #215: LOG4J2-2427 log4j2 filter for logs with no
markers
URL: https://github.com/apache/logging-log4j2/pull/215#issuecomment-502530133
I was about to merge this but then realized I would have to write the
documentation for it. Is it possible you could update the P
rimal commented on issue #215: LOG4J2-2427 log4j2 filter for logs with no
markers
URL: https://github.com/apache/logging-log4j2/pull/215#issuecomment-502552778
@rgoers I have added the documentation. Now the check is giving a build
error. Not sure why, because I have not changed any code.
rimal commented on issue #215: LOG4J2-2427 log4j2 filter for logs with no
markers
URL: https://github.com/apache/logging-log4j2/pull/215#issuecomment-502570294
> @rgoers I have added the documentation. Now the check is giving a build
error. Not sure why, because I have not changed any code
hupfdule opened a new pull request #280: [LOG4J2-2403] Allow zero padding of
integer values
URL: https://github.com/apache/logging-log4j2/pull/280
Alternative to https://github.com/apache/logging-log4j2/pull/224 with less
impact on other files.
This alternative uses the the form `%i
hupfdule commented on issue #224: [LOG4J2-2403] Allow zero padding the counter
of a RollingFileAppender
URL: https://github.com/apache/logging-log4j2/pull/224#issuecomment-502725794
Thank you for taking the time to review this PR!
I have prepared an [alternative
PR](https://github.
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502745552
@carterkozak Please try the latest change I made on the release-2.x branch
and see if it addresses the issue for you. I simply increased
carterkozak commented on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502748224
I was able to reproduce this failure on a mac, so I don't think it had to do
with windows. I'll give it a run and check if I can s
rgoers closed pull request #93: modification to resolver to discover jar
assests without the manipula…
URL: https://github.com/apache/logging-log4j2/pull/93
This is an automated message from the Apache Git Service.
To respon
rgoers commented on issue #93: modification to resolver to discover jar assests
without the manipula…
URL: https://github.com/apache/logging-log4j2/pull/93#issuecomment-502769701
A modified version of this patch has been applied.
carterkozak commented on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502797492
@rgoers Tests all pass, I cannot reproduce the failure anymore. Thanks!
--
carterkozak closed pull request #277: Suite to reproduce LOG4J2-2613 test flakes
URL: https://github.com/apache/logging-log4j2/pull/277
This is an automated message from the Apache Git Service.
To respond to the message, plea
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502834290
Closing this PR since there is nothing left to do.
This is an automated
rgoers closed pull request #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271
This is an automated message from the Apache Git Service.
To respond to the message, please
carterkozak merged pull request #273: LOG4J2-2606: Substantially improve async
logging performance under heavy load
URL: https://github.com/apache/logging-log4j2/pull/273
This is an automated message from the Apache Git Serv
JCgH4164838Gh792C124B5 commented on issue #271: Proposed fix for LOG4J2-2610
rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502935392
Hello Again.
Thanks for looking into this issue.
One last comment: It seems like the test case was updat
carterkozak commented on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502937529
the Test failure was due to triggering rollover twice within a single
interval of the smallest date component (millisecond) withou
rgoers commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502940112
To echo Carter's comment, anytime multiple rollovers can occur within the
"time window" there is a risk that the file being rolled over
rgoers edited a comment on issue #271: Proposed fix for LOG4J2-2610 rollover
issue:
URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-502940112
To echo Carter's comment, anytime multiple rollovers can occur within the
"time window" there is a risk that the file being roll
rgoers merged pull request #215: LOG4J2-2427 log4j2 filter for logs with no
markers
URL: https://github.com/apache/logging-log4j2/pull/215
This is an automated message from the Apache Git Service.
To respond to the message,
2001 - 2100 of 7264 matches
Mail list logo
