remkop commented on issue #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#issuecomment-502506715 Thanks for the reminder! I thought a synchronized block would express the intentions better because it’s simpler. The PR introduces a system property `AsyncLogger.AsyncQueueFullEnqueueSemaphorePermits` that suggests that users can configure multiple permits but I’m not clear on when users should or shouldn’t do this, and what the trade-offs are for configuring multiple permits. If there’s an actual use case for this then it’s fine. If it’s just future-proofing then I’d prefer not to make it configurable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
