carterkozak commented on a change in pull request #278: LOG4J2-2631:
RoutingAppender PurgePolicy implementations don't remove …
URL: https://github.com/apache/logging-log4j2/pull/278#discussion_r294096817
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/routing/RoutingAppender.java
##########
@@ -279,8 +290,12 @@ private Appender createAppender(final Route route, final
LogEvent event) {
return null;
}
+ /**
+ * Returns an unmodifiable view of the appenders created by this {@link
RoutingAppender}.
+ * Note that this map does not contain appenders that are routed by
reference.
+ */
public Map<String, AppenderControl> getAppenders() {
- return Collections.unmodifiableMap(appenders);
+ return createdAppendersUnmodifiableView;
}
Review comment:
Concerns with this behavior change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
