JCgH4164838Gh792C124B5 commented on issue #271: Proposed fix for LOG4J2-2610 rollover issue: URL: https://github.com/apache/logging-log4j2/pull/271#issuecomment-498075200 Hello @rgoers . I updated to the latest release-2.x and re-ran the regression. Your change and updated unit test passed for me. 👍 However, the other issue identified in this PR (item 4 in the summary text) and mentioned in the associated Jira still causes RollingAppenderSizeWithTimeTest to fail: ``` [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.525 s <<< FAILURE! - in org.apache.logging.log4j.core.appender.rolling.RollingAppenderSizeWithTimeTest [ERROR] testAppender(org.apache.logging.log4j.core.appender.rolling.RollingAppenderSizeWithTimeTest) Time elapsed: 6.525 s <<< FAILURE! java.lang.AssertionError: Log messages lost : 217 at org.apache.logging.log4j.core.appender.rolling.RollingAppenderSizeWithTimeTest.testAppender(RollingAppenderSizeWithTimeTest.java:95) ``` So far the 1ms sleep in RollingFileManager.createFileAfterRollover() (also in this PR) is the only mitigation found that works. This failure is being tracked by LOG4J2-2613, so is it OK to leave this PR open until a better solution is determined ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
