mirec75 commented on issue #49: Fixes LOG4NET-630 Log4Net missing Timestamp etc. in internal LogLog URL: https://github.com/apache/logging-log4net/pull/49#issuecomment-496320095 Hi Dominik, with adding the %message to the pattern I was torn between adding it directly and between not, because of the fact, that the message is already preformated (log4net + level + message) and there is no Type.FullName (i.e. %logger) covertor in PatternString converting, although the type is provided in LogLog... but now you persuaded me to your proposal :) Do you think I shall use the `LoggingEvent` and the whole Layout Patterns for formatting somehow? For a quick solution with LoggingEvent I am little bit lost in the whole complexity. Maybe I can have a deeper look at it. Or if I keep using the PatternString, shall I print also the %logger (type full name) between the "log4net:" + level + %logger + message without configuring it in the "LogMsgPattern"? What do you suggest? And according to the `ThreadIdPatternConverter` - which branch (name) shall I create for a sake of this new pull request? Shall there be a new JIRA issue for it? Thanks for your suggestions. I added the rights to my fork for you. Feel free to update my fork with your suggestions! :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
