carterkozak commented on a change in pull request #273: LOG4J2-2606: Substantially improve async logging performance under heavy load URL: https://github.com/apache/logging-log4j2/pull/273#discussion_r287164125
########## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java ########## @@ -153,4 +155,45 @@ public Long call() { throw new IllegalStateException(msg, ex); } } + + /** + * Creates a new {@link Semaphore} or null based on + * <pre>AsyncLogger.AsyncQueueFullEnqueueSemaphorePermits</pre>. + */ + static Semaphore createAsyncLoggerQueueFullEnqueueSemaphore() { + return createAsyncQueueFullEnqueueSemaphore("AsyncLogger.AsyncQueueFullEnqueueSemaphorePermits"); + } + + /** + * Creates a new {@link Semaphore} or null based on + * <pre>AsyncLoggerConfig.AsyncQueueFullEnqueueSemaphorePermits</pre>. + */ + static Semaphore createAsyncConfigQueueFullEnqueueSemaphore() { + return createAsyncQueueFullEnqueueSemaphore("AsyncLoggerConfig.AsyncQueueFullEnqueueSemaphorePermits"); + } Review comment: TODO: Add these properties to our documentation. I'm holding off until we're happy with the design. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services