rgoers commented on a change in pull request #145: fix bug LOG4J2-2211
URL: https://github.com/apache/logging-log4j2/pull/145#discussion_r200211890
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##########
@@ -973,7 +973,8 @@ private int substitute(final LogEvent event, final
StringBuilder buf, final int
priorVariables.add(varName);
// resolve the variable
- String varValue = resolveVariable(event,
varName, buf, startPos, endPos);
+ //String varValue = resolveVariable(event,
varName, buf, startPos, endPos);
+ String varValue = resolveVariable(event,
,varNameExpr buf, startPos, endPos);
Review comment:
How does this line even compile?
I am also concerned that this change means that dynamically constructed
variable names would no longer be supported, which is a breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
