[Lldb-commits] [PATCH] D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`

This revision was automatically updated to reflect the committed changes. Closed by commit rG50b40b051890: [lldb] Improve error reporting in `lang objc tagged-pointer info` (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

JDevlieghere added a comment. I was talking to Jim about this offline and one potential solution would be to have a flag that asks the current script interpreter for some of this relevant information. What that means would be different for every language, so the output would have to be able to

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: friss, jasonmolenda. Herald added subscribers: arphaman, kristof.beyls. JDevlieghere requested review of this revision. Remove the nested switches from the ARMGetSupportedArchitectureAtIndex implementation. I considered a few alter

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:573 +static const char *g_arm64_compatible_archs[] = { +"arm64","armv7","armv7f", "armv7k", "armv7s", "armv7m", +"armv7em", "armv6m", "armv6

[Lldb-commits] [PATCH] D113159: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex

JDevlieghere created this revision. JDevlieghere added reviewers: friss, jasonmolenda. Herald added subscribers: arphaman, kristof.beyls. JDevlieghere requested review of this revision. Don't set the OS when computing supported architectures in PlatformDarwin::ARMGetSupportedArchitectureAtIndex.

[Lldb-commits] [PATCH] D113184: [lldb] Fix cross-platform kills

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/functionalities/gdb_remote_client/TestPlatformKill.py:17-27 +class MyResponder(MockGDBServerResponder): +def _

[Lldb-commits] [PATCH] D113314: [lldb] Use std::string instead of llvm::Twine

JDevlieghere created this revision. JDevlieghere added a reviewer: mgorny. JDevlieghere requested review of this revision. >From the documentation: > A Twine is not intended for use directly and should not be stored, its > implementation relies on the ability to store pointers to temporary stack

[Lldb-commits] [PATCH] D113314: [lldb] Use std::string instead of llvm::Twine

JDevlieghere marked an inline comment as done. JDevlieghere added a subscriber: david. JDevlieghere added a comment. @David: Yes, I considered it, but I think this is slightly more readable. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:11

[Lldb-commits] [PATCH] D113314: [lldb] Use std::string instead of llvm::Twine

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG6d48e2505c7a: [lldb] Use std::string instead of llvm::Twine in GDBRemoteCommunicationClient (authored by JDevlieghere). Herald added a project: LLDB. Changed

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:558 +struct CompatibleArchs { + const char **archs = nullptr; labath wrote: > Is this any different from an `A

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG05fbe758906e: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed p

[Lldb-commits] [PATCH] D113159: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd7a2bf94b69: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D113159?vs=384624

[Lldb-commits] [PATCH] D113445: Support looking up absolute symbols

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113445/new/ https://reviews.llvm.org/D113445 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D109101: [lldb] Add an option to specify a VFS overlay

JDevlieghere abandoned this revision. JDevlieghere added a comment. Looks like there's an easier way to test this, so no need to add another SB API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109101/new/ https://reviews.llvm.org/D109101 __

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

JDevlieghere added a comment. Rather than percolating up a JSON string, we should use `StructuredData` (and `SBStructuredData` at the SB API layer) and only convert it to JSON at the very last moment. Comment at: lldb/tools/driver/Driver.cpp:410 +} else { + llvm::err

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/stack_core_scripted_process.py:1 +import os,struct,signal + mib wrote: > JDevlieghere wrote: > > This should live next to the test. I don't see a point of shipping this to > >

[Lldb-commits] [PATCH] D112107: [lldb] Fix Scripted ProcessLaunchInfo Argument nullptr deref

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks. This LGTM! Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.h:36 std::string m_class_name; -StructuredData::DictionarySP m_dictio

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

JDevlieghere added a comment. Some of the formatting in the Python tests seems a little off (can you run it through something like yapf ?). Other than that this LGTM with the inline comments addressed. Comment at: lldb/test/API/functionalities

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

JDevlieghere added a comment. A few small nits but I'm very happy with the approach. Thanks Larry! Comment at: lldb/include/lldb/API/SBHostOS.h:23 + const char *GetScriptInterpreterInfo(); + Is still still relevant? Comment at: lldb/test/A

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 ___

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

JDevlieghere added a comment. Hi David, this looks really comprehensive. As far as the code is concerned, it has all the parts that we'd want to support another scripting language in LLDB. That leaves us with the last remaining questions: - Testing: having a bot that actually builds & tests thi

[Lldb-commits] [PATCH] D113598: [debugserver] Remove unused variable

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. JDevlieghere requested review of this revision. https://reviews.llvm.org/D113598 Files: lldb/tools/debugserver/source/RNBRemote.cpp Index: lldb/tools/debugserver/source/RNBRemote.cpp =

[Lldb-commits] [PATCH] D113598: [debugserver] Remove unused variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG18d883cc0a06: [debugserver] Remove varaible `ldb_set` which is set but not used. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112167/new/ https://reviews.llvm.org/D112167 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:330-331 + /// NB: This implementation is mutually recursive with + /// GetSupportedArchitectureAtIndex. Subclasses should implement at least one + /// of them. + virtual std::vector GetSupport

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Target/Platform.cpp:1217-1218 +std::vector +Platform::CreateArchList(llvm::Triple::OSType os, + llvm::ArrayRe

[Lldb-commits] [PATCH] D113965: [NFC] Refactor symbol table parsing.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113965/new/ https://reviews.llvm.org/D113965 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/ https://reviews.llvm.org/D112972 ___

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM if the Windows bot is happy :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 ___

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1217-1218 +std::vector +Platform::CreateArchList(llvm::Triple::OSType os, + llvm::ArrayRef archs) { + std::vector list; labath wrote: > JDevlieghere wrote: >

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo the inline comment. Comment at: lldb/include/lldb/Symbol/Type.h:204 // the remaining type scope (namespaces/classes). - static bool GetTypeScopeAndBasename(const llvm::StringRef& name, + static

[Lldb-commits] [PATCH] D114111: Remove a useless temporary of a base class type.

JDevlieghere added a comment. @labath Do you know what the status is of removing RenderScript altogether? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114111/new/ https://reviews.llvm.org/D114111 ___ ll

[Lldb-commits] [PATCH] D114150: [lldb] Deobfuscate python-swigsafecast.swig

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114150/new/ https://reviews.llvm.org/D114150

[Lldb-commits] [PATCH] D114259: [lldb] Fix [some] leaks in python bindings

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice cleanup. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114259/new/ https://reviews.llvm.org/D114259

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

JDevlieghere added a comment. I can't speak to the correctness of the Windows parts, but all the utility function stuff looks sane to me. LGTM if Pavel has no outstanding objections. Comment at: lldb/source/Plugins/Platform/Windows/PlatformWindows.h:47-51 + uint32_t DoLoadIma

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114554/new/ https://reviews.llvm.org/D114554 ___

[Lldb-commits] [PATCH] D114369: [lldb] Remove 'extern "C"' from the lldb-swig-python interface

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114369/new/ https://reviews.llvm.org/D114369 _

[Lldb-commits] [PATCH] D114742: [lldb] Search PrivateFrameworks when using an internal SDK

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda. JDevlieghere requested review of this revision. Herald added a project: LLDB. Make sure to add the PrivateFrameworks directory to the frameworks path when using an internal SDK. This is necessary for the "on-

[Lldb-commits] [PATCH] D114742: [lldb] Search PrivateFrameworks when using an internal SDK

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/builders/darwin.py:86 +private_frameworks = os.path.join(sdk_root, 'System','Library','PrivateFrameworks') +args['FRAMEWORK_INCLUDES'] = '-F{}'.format(private_fram

[Lldb-commits] [PATCH] D114742: [lldb] Search PrivateFrameworks when using an internal SDK

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a302f666737: [lldb] Search PrivateFrameworks when using an internal SDK (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D114742?vs=390473&id=390763#toc Repository: rG L

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. JDevlieghere requested review of this revision. Split TestCxxChar8_t into two parts: one that check reading variables without a process and another part with. This allows us to skip the former on Apple Silicon, wh

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

JDevlieghere added inline comments. Comment at: lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py:22 self.build() - lldbutil.run_to_breakpoint_make_target(self) The name of this helper method is terribly confusing. I had to look at the source

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py:40-43 +lldbutil.run_to_breakpoint_make_target(self) + lldbutil.run_break_set_by_source_regexp(self, "// break here", "-

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

JDevlieghere updated this revision to Diff 391168. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Address Jim's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114819/new/ https://reviews.llvm.org/D114819 Files: lldb/test/API/lang/cpp/char8_t/TestC

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f329cee4237: [lldb] Split TestCxxChar8_t (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114819/new/

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114973/new/ https://reviews.llvm.org/D114973 ___

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

JDevlieghere added a comment. Can we add a small test for the error messages? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114923/new/ https://reviews.llvm.org/D114923 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D132596: [lldb][nfc] Remove unused makefile test variables

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, I meant to remove those in a previous patch. Thanks for following up on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D132694: [lldb] Quietly source lit-lldb-init

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132694/new/ https://reviews.llvm.org/D132694 ___

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

JDevlieghere added inline comments. Comment at: lldb/test/API/CMakeLists.txt:166 +set(LLDB_TEST_COMMON_ARGS ${LLDB_TEST_COMMON_ARGS_VAR} CACHE INTERNAL STRING) + Instead of having two variables, why not move this to line 40 and make `LLDB_TEST_COMMON_ARGS` a c

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

JDevlieghere updated this revision to Diff 455725. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. I added the ability to call `ObjectContainer::FindPlugin` which allows you to create a Mach-O fileset from memory without actually having to know it's a fileset. I thin

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48506fbbbf27: [lldb] Teach LLDB about Mach-O filesets (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D132710: [lldb] Computer and apply the slide to the fileset entry's vmaddr

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Computer and apply the slide to the fileset entry's vmaddr when reading a fileset from memory. https://reviews.llvm.org/D132710 Files:

[Lldb-commits] [PATCH] D132709: [lldb][ClangExpression] Fix LLDB_LOG incorrect format specifier

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132709/new/ https://reviews.llvm.org/D132709 ___

[Lldb-commits] [PATCH] D132710: [lldb] Computer and apply the slide to the fileset entry's vmaddr

This revision was automatically updated to reflect the committed changes. Closed by commit rGe360281fa710: [lldb] Computer the slide when and apply it to each fileset's vm addr (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D132710?vs

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/CMakeLists.txt:166 +set(LLDB_TEST_COMMON_ARGS ${LLDB_TEST_COMMON_ARGS_VAR} CACHE INTERNAL STRING) + fdeazeve wro

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo inline comment. Comment at: lldb/docs/resources/fuzzing.rst:15-17 + $ -DLLVM_USE_SANITIZER='Address' + $ -DLLVM_USE_SANITIZE_COVERAGE=On + $ -DC

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:75-76 + name.startswith("unordered_multimap<") || + name.startswith("std::__1::unordered_map<") || + name.startswith("std::__1::unordered_multimap

[Lldb-commits] [PATCH] D132775: [lldb][docs] Fix formatting in fuzzing doc

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132775/new/ https://reviews.llvm.org/D132775 ___

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117383/new/ https://reviews.llvm.org/D117383 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D132803: [lldb][test] Speed up lldb arch determination (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132803/new/ https://reviews.llvm.org/D132803 ___

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

JDevlieghere added a comment. The test that's using `iostream` could be rewritten to use `printf` instead. It actually looks like most of those test can be compiled as C programs, which should speed this up even more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 ___

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

JDevlieghere added a comment. In D132868#3758826 , @labath wrote: > I don't think this will work in general, as the modules feature requires all > your dependencies to be modularized, and linux systems generally don't have > that. You might be able to d

[Lldb-commits] [PATCH] D132973: [lldb] Fix two bugs in ObjectContainerMachOFileset when reading from memory

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a reviewer: ributzka. Herald added a project: All. JDevlieghere requested review of this revision. Jason caught two issues in the memory part of ObjectContainerMachOFileset which I didn't hook up and the

[Lldb-commits] [PATCH] D132973: [lldb] Fix two bugs in ObjectContainerMachOFileset when reading from memory

This revision was automatically updated to reflect the committed changes. Closed by commit rG0044cb4b2037: [lldb] Fix two bugs in ObjectContainerMachOFileset (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D133046: [lldb] Make the `rumtimes` target a test dependency

JDevlieghere created this revision. JDevlieghere added reviewers: fdeazeve, jingham. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Make the `rumtimes` target a test dependency https://reviews.llvm.org/D133046 Files: lldb/test/C

[Lldb-commits] [PATCH] D133046: [lldb] Make the `rumtimes` target a test dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rGf328922f55fe: [lldb] Make the rumtimes target a test dependency (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp:584 +triple.setArchName("arm64"); +target_arch.SetTriple(triple); +target.SetArchitecture(target_arch, /*set_platform=*/false, --

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp:584 +triple.setArchName("arm64"); +target_arch.SetTriple(triple); +target.SetArchitecture(target_arch, /*set_platform=*/false, --

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Jim is looking into adding support for interrupts to the SB API. Part of that work requires clearing the inte

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133130/new/ https://reviews.llvm.org/D133130 _

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. That test is not going to win any beauty pageants but it looks like it gets the job done. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133069/new/ https://reviews.

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:70 +static void consumeNamespace(llvm::StringRef &name) { + // Delete past an inline namespace, if any: __[a-zA-Z0-9_]+:: rupprecht wrote: > nit: this

[Lldb-commits] [PATCH] D133393: [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments.

JDevlieghere added inline comments. Comment at: lldb/unittests/TestingSupport/Host/SocketTestUtilities.h:50 +/// is detected. If neither are detected, return an error. +llvm::Expected GetLocalhostIp(); + nit Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:396 + ifneq ($(or $(USE_LIBSTDCPP), $(USE_LIBCPP)),) + $(error Cannot use system's library and a custom library toget

[Lldb-commits] [PATCH] D133501: [lldb] Use std::size instead of llvm::array_lengthof

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133501/new/ https://reviews.llvm.org/D133501 ___

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

JDevlieghere added a comment. You'll need to add this to the index.rst page. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133519/new/ https://reviews.llvm.org/D133519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

JDevlieghere added a comment. Content looks good to me, but I'll hold off on accepting the review until the others have had a chance to see this in their review queue. Comment at: lldb/docs/use/extensions.rst:72 + +:: + DW_TAG_compile_unit Missing newline (i

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

JDevlieghere added a comment. The current patch didn't have context so I just left a bunch of nits. Comment at: lldb/include/lldb/Target/Platform.h:870-874 + virtual bool LoadSpecialBinaryAndSetDynamicLoader(Process *process, +

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A small comment but otherwise this LGTM. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp:924 +

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere added inline comments. Comment at: lldb/test/API/lit.cfg.py:94 +def is_configured_and_true(attr): + """Returns true if and only if the configuration attribute exists and it is `is_enabled` maybe? Comment at: lldb/test/API/lit.cf

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere added inline comments. Comment at: lldb/test/API/lit.cfg.py:181-184 +if is_configured_and_true('has_libcxx') and platform.system() != 'Windows': if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): dotest_cmd += ['--libcxx-include-dir', o

[Lldb-commits] [PATCH] D133689: [lldb] Add SBBreakpointLocation::SetCallback

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133689/new/ https://reviews.llvm.org/D133689 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/UserSettingsController.h:62-64 virtual void DumpAllPropertyValues(const ExecutionContext *exe_ctx, - Stream &strm, uint32_t dump_mask); +

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm.org/D133639 __

[Lldb-commits] [PATCH] D131122: [lldb] Fixed a number of typos

This revision was automatically updated to reflect the committed changes. Closed by commit rG7240436c94bd: [lldb] Fixed a number of typos (authored by GabrielRavier, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D131122?vs=449806&id=459801#toc Repository: rG L

[Lldb-commits] [PATCH] D133680: Add support for mach-o corefile loading of a platform binary

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133680/new/ https://reviews.llvm.org/D133680 ___

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

JDevlieghere added inline comments. Comment at: lldb/source/Target/Process.cpp:2763-2766 +static void ResetHitCounts(Process &Proc) { + for (const auto &BP : Proc.GetTarget().GetBreakpointList().Breakpoints()) +BP->ResetHitCount(); +} Can this be a private m

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere created this revision. JDevlieghere added reviewers: mib, aprantl, labath. Herald added a project: All. JDevlieghere requested review of this revision. Generate lldb-forward with .def file. The benefit is that we don't have to keep the list of classes, and typedefs in sync. https:/

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere added a comment. In D133906#3791153 , @jingham wrote: > This patch makes me a little sad because it breaks the "Jump to Definition" > chain in Xcode (and I bet it does in other IDE's that support this.) You > used to be able to do "Jump to

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere added a comment. In D133906#3792230 , @labath wrote: > In D133906#3791352 , @JDevlieghere > wrote: > >> In D133906#3791153 , @jingham >> wrote: >> >>> This

[Lldb-commits] [PATCH] D133961: [lldb] Use SWIG_fail in python-typemaps.swig (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133961/new/ https://reviews.llvm.org/D133961 ___

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

JDevlieghere added a comment. Do we need both `LIBCPP_INCLUDE_DIR` and `LIBCPP_INCLUDE_TARGET_DIR`? I see we pass another `-cxx-isystem` flag, does this result in another search path or does that replace the former? If we only need one, we could set `LIBCPP_INCLUDE_DIR` to `libcxx_include_targe

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/test/API/lit.cfg.py:178-179 + dotest_cmd += ['--libcxx-include-dir', config.libcxx_include_dir] + if is_configured('libcxx_include_target_dir'): +dotest_cmd += ['--libcxx-

[Lldb-commits] [PATCH] D134245: [lldb] Actually support more than 32 logging categories

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. In January, Greg put up a patch (D117382 ) to support more than 32 log categories, among other things.

[Lldb-commits] [PATCH] D134245: [lldb] Actually support more than 32 logging categories

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b4db10f3492: [lldb] Actually support more than 32 logging categories (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D134245?vs=461420&id=461

[Lldb-commits] [PATCH] D134244: [NFCI] Clean up enum FormatCategoryItem.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM modulo the enum values. Comment at: lldb/include/lldb/lldb-private-enumerations.h:131-134 eFormatCategoryItemSummary = 0x0001, - eFormatCate

[Lldb-commits] [PATCH] D134751: [lldb] Fix running tests when LLVM target triple is different from host

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Supporting builds with different host and target triples makes sense. However, I have a few concerns about the current patch: - I wouldn't cal it the "host triple". The A

[Lldb-commits] [PATCH] D134508: Track which modules have debug info variable errors.

JDevlieghere added a comment. Instead of storing a bool, would it make sense to store the error instead and then have the statistics call `isFail` on it to determine whether there was an issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134508/

<    17   18   19   20   21   22   23   24   25   26   >