JDevlieghere added a comment. I can't speak to the correctness of the Windows parts, but all the utility function stuff looks sane to me. LGTM if Pavel has no outstanding objections.
================ Comment at: lldb/source/Plugins/Platform/Windows/PlatformWindows.h:47-51 + uint32_t DoLoadImage(lldb_private::Process *process, + const lldb_private::FileSpec &remote_file, + const std::vector<std::string> *paths, + lldb_private::Status &error, + lldb_private::FileSpec *loaded_path) override; ---------------- I know it's an `override`, but what a horrible interface... ================ Comment at: lldb/test/Shell/Process/Windows/process_load.cpp:3 + +// REQUIRES: system-windows +// RUN: %build --compiler=clang-cl -o %t.exe -- %s ---------------- compnerd wrote: > JDevlieghere wrote: > > We should probably have a `lit.local.cfg` in the Windows directory with > > > > ``` > > if 'system-windows' not in config.available_features: > > config.unsupported = True > > > > ``` > I think that's a good idea, but, should be a separate change - it isn't > related to the load/unload functionality. Fair enough CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
