JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, jasonmolenda.
JDevlieghere requested review of this revision.
Herald added a project: LLDB.

Make sure to add the PrivateFrameworks directory to the frameworks path when 
using an internal SDK. This is necessary for the "on-device" test suite.

rdar://84519268


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114742

Files:
  lldb/packages/Python/lldbsuite/test/builders/darwin.py


Index: lldb/packages/Python/lldbsuite/test/builders/darwin.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/builders/darwin.py
+++ lldb/packages/Python/lldbsuite/test/builders/darwin.py
@@ -79,6 +79,12 @@
         if configuration.dsymutil:
             args['DSYMUTIL'] = configuration.dsymutil
 
+        if 'internal' in configuration.apple_sdk:
+            sdk_root = lldbutil.get_xcode_sdk_root(configuration.apple_sdk)
+            if sdk_root:
+                private_frameworks = os.path.join(sdk_root, 
'System','Library','PrivateFrameworks')
+                args['FRAMEWORK_INCLUDES'] = '-F{}'.format(private_frameworks)
+
         operating_system, env = get_os_and_env()
         if operating_system and operating_system != "macosx":
             builder_dir = os.path.dirname(os.path.abspath(__file__))


Index: lldb/packages/Python/lldbsuite/test/builders/darwin.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/builders/darwin.py
+++ lldb/packages/Python/lldbsuite/test/builders/darwin.py
@@ -79,6 +79,12 @@
         if configuration.dsymutil:
             args['DSYMUTIL'] = configuration.dsymutil
 
+        if 'internal' in configuration.apple_sdk:
+            sdk_root = lldbutil.get_xcode_sdk_root(configuration.apple_sdk)
+            if sdk_root:
+                private_frameworks = os.path.join(sdk_root, 'System','Library','PrivateFrameworks')
+                args['FRAMEWORK_INCLUDES'] = '-F{}'.format(private_frameworks)
+
         operating_system, env = get_os_and_env()
         if operating_system and operating_system != "macosx":
             builder_dir = os.path.dirname(os.path.abspath(__file__))
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to