JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM modulo the inline comment.
================
Comment at: lldb/include/lldb/Symbol/Type.h:204
// the remaining type scope (namespaces/classes).
- static bool GetTypeScopeAndBasename(const llvm::StringRef& name,
+ static bool GetTypeScopeAndBasename(const llvm::StringRef &name,
llvm::StringRef &scope,
----------------
Since you're touching this line... The coding standards say that StringRefs
should always be passed by-value:
> StringRef is small and pervasive enough in LLVM that it should always be
> passed by value.
https://llvm.org/docs/ProgrammersManual.html#the-stringref-class
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113604/new/
https://reviews.llvm.org/D113604
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
