JDevlieghere added inline comments.
================
Comment at: lldb/test/API/lit.cfg.py:94
+def is_configured_and_true(attr):
+ """Returns true if and only if the configuration attribute exists and it is
----------------
`is_enabled` maybe?
================
Comment at: lldb/test/API/lit.cfg.py:181-184
+if is_configured_and_true('has_libcxx') and platform.system() != 'Windows':
if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'):
dotest_cmd += ['--libcxx-include-dir',
os.path.join(config.llvm_include_dir, 'c++', 'v1')]
dotest_cmd += ['--libcxx-library-dir', config.llvm_libs_dir]
----------------
Are there other places where this helper would be useful? If not I think we can
check the value directly. With the helper we lose a little bit of signal (if it
returns false, was it not configured or set to false?). I don't think it's a
big deal, but those two things combined make me favor inlining the check.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133639/new/
https://reviews.llvm.org/D133639
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
