JDevlieghere added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/builders/darwin.py:86
+ private_frameworks = os.path.join(sdk_root,
'System','Library','PrivateFrameworks')
+ args['FRAMEWORK_INCLUDES'] = '-F{}'.format(private_frameworks)
+
----------------
aprantl wrote:
> Just curious: why not
> ```
> args['FRAMEWORK_INCLUDES'] = '-F' + private_frameworks
> ```
> ?
Mostly for consistency with the rest of the file, but also personal preference.
It's no coincidence that the rest of the file uses `format` too. I like
f-strings even more, but they're Python 3.something only.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114742/new/
https://reviews.llvm.org/D114742
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
