[Lldb-commits] [PATCH] D153710: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We always assume the Stream pointer is valid, might as well be t

[Lldb-commits] [PATCH] D153711: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We are assuming that the pointer is always valid, might as well

[Lldb-commits] [PATCH] D153710: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG718e0cd6e724: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[Lldb-commits] [PATCH] D153711: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f69e6682bf0: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D153673: [lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

This revision was automatically updated to reflect the committed changes. Closed by commit rG2014572d9a68: [lldb][NFCI] Remove unneeded ConstString constructions for… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153673/new/

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

bulbazord added a comment. In D153657#4449608 , @jingham wrote: > In D153657#4445292 , @bulbazord > wrote: > >> I think this patch is probably okay to do, but it does break a supported use >> case that I'm aware

[Lldb-commits] [PATCH] D153675: [lldb][NFCI] Remove ConstString from Process::ConfigureStructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rG9442e81f02a7: [lldb][NFCI] Remove ConstString from Process::ConfigureStructuredData (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

bulbazord added inline comments. Comment at: lldb/source/Host/common/FileSystem.cpp:230 SmallString<128> resolved(path.begin(), path.end()); StandardTildeExpressionResolver Resolver; + m_tilde_resolver->ResolveFullPath(llvm::StringRef(path.begin(), path.size()), --

[Lldb-commits] [PATCH] D153810: [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, Michael137, augusto2112, kastiglione, fdeazeve. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commi

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jasonmolenda, jingham, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The shared cache has grown past the previou

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord added a comment. In D153817#4450534 , @jasonmolenda wrote: > LGTM. You might want to mention why it isn't sustainable -- because we must > allocate memory in the inferior process, and some inferior processes have > quite small memory limits.

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord updated this revision to Diff 534753. bulbazord added a comment. Update FIXME with more info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153817/new/ https://reviews.llvm.org/D153817 Files: lldb/source/Plugins/LanguageRuntime/ObjC/Ap

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord updated this revision to Diff 534757. bulbazord added a comment. Updating number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153817/new/ https://reviews.llvm.org/D153817 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRunti

[Lldb-commits] [PATCH] D153818: [lldb][NFCI] Remove use of ConstString from PluginManager

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The underlying structures no longer use ConstString so we can rem

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ed3c2edf017: [lldb] Increase the maximum number of classes we can read from shared cache (authored by bulbazord). Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D153824: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Now that we have a proper way to deprecate things i

[Lldb-commits] [PATCH] D153825: [lldb][NFCI] Change return type of GetProcessPluginName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of just returning a raw `const char *`, I think llvm::Str

[Lldb-commits] [PATCH] D153827: [lldb][NFCI] Remove use of ConstString from ProcessElfCore

bulbazord created this revision. bulbazord added reviewers: clayborg, DavidSpickett, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm not convinced that it makes sense for the paths to

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153726/new/ https://reviews.llvm.org/D153726 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. LGTM with a few nits. There is one piece of logic that I think does need to be changed before this can go in however. Comment at: lldb/source/Commands/Comman

[Lldb-commits] [PATCH] D153818: [lldb][NFCI] Remove use of ConstString from PluginManager

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec083107ff2: [lldb][NFCI] Remove use of ConstString from PluginManager (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153818/new/ h

[Lldb-commits] [PATCH] D153824: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd69ae0c5a7: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, teemperor, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For some context, Raphael tried to this befo

[Lldb-commits] [PATCH] D153905: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, Michael137, augusto2112, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. 2/3 of the ConstStrings in this class wer

[Lldb-commits] [PATCH] D153905: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

bulbazord updated this revision to Diff 535084. bulbazord added a comment. Remove unneeded newline from log line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153905/new/ https://reviews.llvm.org/D153905 Files: lldb/source/Plugins/ExpressionPars

[Lldb-commits] [PATCH] D153917: [lldb][NFCI] Target::StopHook::GetDescription should take a Stream ref instead of pointer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We always assume that this is valid anyway, might as well take a

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This method, as far as I can ascertain, is non-triv

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

bulbazord added inline comments. Comment at: lldb/include/lldb/API/SBValue.h:286 + LLDB_DEPRECATED("SBValue::GetOpaqueType() is deprecated. Do not use.", "") void *GetOpaqueType(); mib wrote: > JDevlieghere wrote: > > Similar comment as in D153900: The "Do

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We already have LLDB_DEPRECATED which is used to mark methods as

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

bulbazord added inline comments. Comment at: lldb/include/lldb/lldb-defines.h:134-140 +#if defined(__clang__) +#define LLDB_UNSUPPORTED(MSG) \ + __attribute__((deprecated("This method is no longer supported: " MSG, ""))) +#else +

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

bulbazord updated this revision to Diff 535199. bulbazord added a comment. Implement changes after discussing offline with Jonas and Ismail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153928/new/ https://reviews.llvm.org/D153928 Files: lldb/in

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

bulbazord added a comment. Making `m_lock_count`'s type into `std::atomic` makes sense to me, but I'm a little confused about why `Process::LoadOperatingSystemPlugin` is guarded by acquiring `m_thread_mutex`. My (admittedly limited) understanding of that is that it's a mutex that the Process ho

[Lldb-commits] [PATCH] D153905: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

This revision was automatically updated to reflect the committed changes. Closed by commit rG673f91055a41: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D153810: [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2ff2921e84a: [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D153825: [lldb][NFCI] Change return type of GetProcessPluginName

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b102886c0c3: [lldb][NFCI] Change return type of GetProcessPluginName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153825/new/ htt

[Lldb-commits] [PATCH] D153827: [lldb][NFCI] Remove use of ConstString from ProcessElfCore

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3921b8bff69: [lldb][NFCI] Remove use of ConstString from ProcessElfCore (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153827/new/

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

This revision was automatically updated to reflect the committed changes. Closed by commit rGebec53e2d7c7: [lldb] Introduce a macro to mark methods as unsupported with no replacement (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153834/new/ https://reviews.llvm.org/D153834 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D153917: [lldb][NFCI] Target::StopHook::GetDescription should take a Stream ref instead of pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rGb709149b7627: [lldb][NFCI] Target::StopHook::GetDescription should take a Stream ref instead… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

bulbazord updated this revision to Diff 536864. bulbazord added a comment. Reword deprecation message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://reviews.llvm.org/D153900 Files: lldb/include/lldb/API/SBHostOS.h lldb/tools

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

bulbazord updated this revision to Diff 536865. bulbazord added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153918/new/ https://reviews.llvm.org/D153918 Files: lldb/include/lldb/API/SBValue.h Index: lldb/include/l

[Lldb-commits] [PATCH] D154386: [lldb][NFCI] Remove use of ConstString from OptionValue

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. No need to create a ConstString, `GetName` already returns a StringRef.

[Lldb-commits] [PATCH] D154386: [lldb][NFCI] Remove use of ConstString from OptionValue

bulbazord updated this revision to Diff 536873. bulbazord added a comment. Small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154386/new/ https://reviews.llvm.org/D154386 Files: lldb/source/Interpreter/OptionValue.cpp Index: lldb/source/I

[Lldb-commits] [PATCH] D154387: [lldb][NFCI] Minor cleanup of default OptionValue::GetSubValue implementation

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This does 2 things: - Corrects a minor typo (`value subvalue` -> `valid s

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

bulbazord added a comment. I'm a big fan of refactoring deeply-nested code to be flatter, so I'm happy to see this work being done! I wasn't aware of `llvm::concat` before, I probably would have used a lambda or something to do this, so it was interesting learning about that. 😄 =

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c7c9970379e: [lldb] Deprecate SBHostOS threading functionality (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://r

[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

bulbazord commandeered this revision. bulbazord added a reviewer: teemperor. bulbazord added a comment. Herald added a project: All. Commandeering this change in order to close it. I've effectively done this already with D153900 . CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

bulbazord added a comment. In D153900#4469649 , @mib wrote: > LGTM! @bulbazord when you land this, make sure to close @teemperor's diff > (D104231 ). Thanks! 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

This revision was automatically updated to reflect the committed changes. Closed by commit rG20f99278dbb8: [lldb][NFCI] Deprecate SBValue::GetOpaqueType (authored by bulbazord). Herald added a subscriber: wangpc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D154387: [lldb][NFCI] Minor cleanup of default OptionValue::GetSubValue implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd5748cb5a45: [lldb][NFCI] Minor cleanup of default OptionValue::GetSubValue implementation (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D154530: [lldb] Fix incorrect uses of LLDB_LOG_ERROR

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I was actually looking at this today independently, guess you beat me to the punch 😛 . LGTM modulo one comment. Comment at: lldb/source/Target/Target.cpp:2413-2414

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

bulbazord added a comment. These uses of `LLDB_LOG` are taking errors, consuming them while turning them into strings, and logging them. Unless I'm missing something, I think it would make more sense to convert these to use `LLDB_LOG_ERROR`. Comment at: lldb/source/Core/Debug

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

bulbazord added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1918-1919 } else { - LLDB_LOG(GetLog(LLDBLog::Host), "failed to launch host thread: {}", + LLDB_LOG(GetLog(LLDBLog::Host), "failed to launch host thread: {0}", llvm::toString

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This accomplishes a few minor things: - Removed unnecessary use

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. The 2nd argument to `LLDB_LOG_ERROR` is the error itself, so these should be something like `LLDB_LOG_ERROR(GetLog(whatever), std::move(err), "message: {0}");` or something to

[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I see you updated it while I typed it up. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154532/new/ https://reviews.llvm.org/D154532 _

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

bulbazord added inline comments. Comment at: lldb/source/Utility/StructuredData.cpp:120 +return value->GetObjectForDotSeparatedPath(match.second); + } else if (GetType() == lldb::eStructuredDataTypeArray) { std::pair match = path.split('['); fdeazeve wr

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

bulbazord updated this revision to Diff 537451. bulbazord added a comment. Remove unneeded `else` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154534/new/ https://reviews.llvm.org/D154534 Files: lldb/source/Utility/StructuredData.cpp Index: l

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

bulbazord added inline comments. Comment at: lldb/source/Utility/StructuredData.cpp:125 +if (match.second.empty()) return this->shared_from_this(); + mib wrote: > Good catch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

bulbazord added a comment. I really like the change to the interface, I especially like that it can report what was interrupted and how much work actually done. I had a lot of the same feedback as Ismail but also had some questions to help me understand all the details. Comm

[Lldb-commits] [PATCH] D154549: [lldb][NFCI] Remove use of Stream * from TypeSystem

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, fdeazeve, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We always assume these streams are valid, might as well

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

bulbazord updated this revision to Diff 537523. bulbazord added a comment. Address feedback from @mib Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154534/new/ https://reviews.llvm.org/D154534 Files: lldb/source/Utility/StructuredData.cpp Inde

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

bulbazord added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:430-431 + template + bool InterruptRequested(const char *cur_func, + const char *formatv, Args &&... args) { +bool ret_val = InterruptRequested(); jing

[Lldb-commits] [PATCH] D154386: [lldb][NFCI] Remove use of ConstString from OptionValue

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc55b0b38446: [lldb][NFCI] Remove use of ConstString from OptionValue (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154386/new/ htt

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f7e41d0400e: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D109384: [lldb] Delete IRExecutionUnit::SearchSpec

bulbazord created this revision. bulbazord added reviewers: clayborg, jingham, teemperor, JDevlieghere. bulbazord requested review of this revision. Herald added a project: LLDB. IRExecutionUnit::SearchSpec is a struct that encapsulates information needed to look for a symbol. Specifically, it is

[Lldb-commits] [PATCH] D109384: [lldb] Delete IRExecutionUnit::SearchSpec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG303b27f21b98: [lldb] Delete IRExecutionUnit::SearchSpec (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D109600: [lldb] Remove PluginInterface::GetPluginVersion

bulbazord accepted this revision. bulbazord added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109600/new/ https://reviews.llvm.org/D109600 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D109779: [LLDB] [Minidump] Fix format string warnings on Windows

bulbazord added a reviewer: MaskRay. bulbazord added a comment. Adding MaskRay who fixed something similar to this yesterday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109779/new/ https://reviews.llvm.org/D109779 __

[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

bulbazord created this revision. bulbazord added reviewers: clayborg, teemperor, jingham, JDevlieghere, labath. bulbazord requested review of this revision. Herald added a project: LLDB. I have 2 goals with this change: 1. Disambiguate between CPlusPlus::FindAlternateFunctionManglings and IRExec

[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h:130 - // Given a mangled function name, calculates some alternative manglings since - // the compiler mangling may not line up with the symbol we are expecting - static ui

[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa65f6aafe2d3: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings (authored by bulbazord). Changed prior to commit: https

[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

bulbazord created this revision. bulbazord added a reviewer: clayborg. bulbazord requested review of this revision. Herald added a project: LLDB. The work that IRExecutionUnit::CollectFallbackNames is basically the work that `CPlusPlusLanguage::GetDemangledFunctionNameWithoutArguments` does alread

[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

bulbazord added a comment. In D109928#3005085 , @clayborg wrote: > Looks fine to me. I am assuming the full test suite passes with this change > in place? It didn't introduce any new test failures on any of my machines. Comment at: l

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

bulbazord created this revision. bulbazord added reviewers: clayborg, jingham, teemperor, JDevlieghere. Herald added a subscriber: mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. This change accomplishes the following: - Moves `IRExecutionUnit::FindBestAlternate

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:524-530 + if (param_and_qual_matches.size()) +return param_and_qual_matches[0]; // It is assumed that there will be only + // one! +

[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

bulbazord added a comment. In D109928#3013627 , @shafik wrote: > I think this looks fine, just verify that this in a C++ case an expression > with an `extern "C"` function call works fine e.g. > > extern "C" { > int g() { return 10;} > } > >

[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43552651319e: [lldb] Remove IRExecutionUnit::CollectFallbackNames (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

bulbazord updated this revision to Diff 374639. bulbazord added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110115/new/ https://reviews.llvm.org/D110115 Files: lldb/include/lldb/Target/Language.h lldb/source/Expression/CM

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

bulbazord added a comment. friendly ping! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110115/new/ https://reviews.llvm.org/D110115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

bulbazord closed this revision. bulbazord added a comment. 385b2189cc44 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110115/new/ https://reviews.llvm.org/D110115 _

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

bulbazord added a comment. This patch effectively introduces a file format to cache lldb internal state. While the tests and the code do give some information for what it looks like, some documentation about this format would be nice. I like this idea a lot! My comments were kind of surface lev

[Lldb-commits] [PATCH] D114719: [lldb] Move non-clang specific method to the generic DWARF Parser

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. This makes sense to me. Out of curiosity, do you have plans to use this for non-clang-based languages? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114719/new/ https://reviews

[Lldb-commits] [PATCH] D114668: [lldb] Move generic DWARFASTParser code out of Clang-specific code

bulbazord added a comment. I think breaking it out of the Clang-specific class makes sense if we want LLDB to be more language-agnostic. Do you have an idea of what bits of `DWARFASTParserClang` can be moved out other than `ParseChildArrayInfo` and `GetAccessTypeFromDWARF` (from the patch on to

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd76375c8009: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D151919?vs=529769&id=557568#toc Repositor

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make use it

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Ok, makes sense to me. Since this is a refactor, I assume that the current test suite should be enough to cover this change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159314

[Lldb-commits] [PATCH] D135825: [LLDB] Only run lldb-server Shell tests if it gets built

bulbazord created this revision. bulbazord added reviewers: labath, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It's easy enough to disable the lldb-server build. The lldb-server unit

[Lldb-commits] [PATCH] D135825: [LLDB] Only run lldb-server Shell tests if it gets built

bulbazord added a comment. In D135825#3855539 , @DavidSpickett wrote: > Would a `lit.local.cfg` work in this folder (`lldb/test/Shell/lldb-server/` > that is)? That would automatically apply it to all existing and future tests. > > `llvm/test/MC/AArch64

[Lldb-commits] [PATCH] D135825: [LLDB] Only run lldb-server Shell tests if it gets built

bulbazord updated this revision to Diff 467587. bulbazord added a comment. Implement David's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135825/new/ https://reviews.llvm.org/D135825 Files: lldb/test/CMakeLists.txt lldb/test/Shell/lit.cfg.py lldb/test/Shell/lit.site.c

[Lldb-commits] [PATCH] D135825: [LLDB] Only run lldb-server Shell tests if it gets built

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cfa50154a47: [LLDB] Only run lldb-server Shell tests if it gets built (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135825/new/ ht

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

bulbazord created this revision. bulbazord added reviewers: clayborg, JDevlieghere, aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Context: I plan on using this change primarily downstream in

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

bulbazord added a comment. I have a pull request to apple's fork to show how this is used for swift: https://github.com/apple/llvm-project/pull/5540 I primarily wanted this portion to be upstream so that the patch is easier to maintain downstream, but it could be useful for clang-produced TypeS

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

bulbazord updated this revision to Diff 472468. bulbazord added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137191/new/ https://reviews.llvm.org/D137191 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Symbol/TypeSystem.h lldb/include/lldb/Ta

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

bulbazord updated this revision to Diff 472672. bulbazord added a comment. Remove `const &` from argument to `Module::ForEachTypeSystem` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137191/new/ https://reviews.llvm.org/D137191 Files: lldb/include/lldb/Core/Module.h lldb/include/ll

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

This revision was automatically updated to reflect the committed changes. Closed by commit rG13cd39017de0: [lldb] Add information on type systems to statistics dump command (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137191

[Lldb-commits] [PATCH] D138237: [lldb] Restore default setting of LLDB_INCLUDE_TESTS in standalone builds

bulbazord created this revision. bulbazord added reviewers: labath, mgorny. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In 52f39853abd46495a6d636c4b035e1b92cf4b833

[Lldb-commits] [PATCH] D138237: [lldb] Restore default setting of LLDB_INCLUDE_TESTS in standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG58d38b3ff8c3: [lldb] Restore default setting of LLDB_INCLUDE_TESTS in standalone builds (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

bulbazord added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptedMetadata.h:9-10 + +#ifndef LLDB_SOURCE_PLUGINS_SCRIPTED_METADATA_H +#define LLDB_SOURCE_PLUGINS_SCRIPTED_METADATA_H + This should be `LLDB_INTERPRETER_SCRIPTEDMETADATA_H` to be con

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

bulbazord accepted this revision. bulbazord added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139247/new/ https://reviews.llvm.org/D139247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord created this revision. bulbazord added a reviewer: teemperor. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are several instances where one may want to ask questions about the name of a method/function/whatever.

<    5   6   7   8   9   10   11   12   13   14   >