bulbazord updated this revision to Diff 535199.
bulbazord added a comment.
Implement changes after discussing offline with Jonas and Ismail
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153928/new/
https://reviews.llvm.org/D153928
Files:
lldb/include/lldb/API/SBCommandReturnObject.h
lldb/include/lldb/API/SBDebugger.h
lldb/include/lldb/API/SBDefines.h
lldb/include/lldb/API/SBFileSpec.h
lldb/include/lldb/API/SBProcess.h
lldb/include/lldb/API/SBStructuredData.h
lldb/include/lldb/API/SBTarget.h
lldb/include/lldb/API/SBValue.h
lldb/include/lldb/lldb-defines.h
Index: lldb/include/lldb/lldb-defines.h
===================================================================
--- lldb/include/lldb/lldb-defines.h
+++ lldb/include/lldb/lldb-defines.h
@@ -125,10 +125,13 @@
#define UNUSED_IF_ASSERT_DISABLED(x) ((void)(x))
+#define LLDB_DEPRECATED(MSG) \
+ [[deprecated("This method is no longer supported: " MSG)]]
+
#if defined(__clang__)
-#define LLDB_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
+#define LLDB_DEPRECATED_FIXME(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
#else
-#define LLDB_DEPRECATED(MSG, FIX) [[deprecated(MSG)]]
+#define LLDB_DEPRECATED_FIXME(MSG, FIX) LLDB_DEPRECATED(MSG)
#endif
#endif // LLDB_LLDB_DEFINES_H
Index: lldb/include/lldb/API/SBValue.h
===================================================================
--- lldb/include/lldb/API/SBValue.h
+++ lldb/include/lldb/API/SBValue.h
@@ -105,8 +105,8 @@
const char *GetLocation();
- LLDB_DEPRECATED("Use the variant that takes an SBError &",
- "SetValueFromCString(const char *, SBError &)")
+ LLDB_DEPRECATED_FIXME("Use the variant that takes an SBError &",
+ "SetValueFromCString(const char *, SBError &)")
bool SetValueFromCString(const char *value_str);
bool SetValueFromCString(const char *value_str, lldb::SBError &error);
@@ -124,7 +124,7 @@
lldb::SBValue CreateChildAtOffset(const char *name, uint32_t offset,
lldb::SBType type);
- LLDB_DEPRECATED("Use the expression evaluator to perform type casting", "")
+ LLDB_DEPRECATED("Use the expression evaluator to perform type casting")
lldb::SBValue Cast(lldb::SBType type);
lldb::SBValue CreateValueFromExpression(const char *name,
@@ -295,7 +295,7 @@
lldb::SBValue Dereference();
- LLDB_DEPRECATED("Use GetType().IsPointerType() instead", "")
+ LLDB_DEPRECATED("Use GetType().IsPointerType() instead")
bool TypeIsPointerType();
lldb::SBType GetType();
Index: lldb/include/lldb/API/SBTarget.h
===================================================================
--- lldb/include/lldb/API/SBTarget.h
+++ lldb/include/lldb/API/SBTarget.h
@@ -396,8 +396,8 @@
/// \return
/// An error to indicate success, fail, and any reason for
/// failure.
- LLDB_DEPRECATED("Use SetModuleLoadAddress(lldb::SBModule, uint64_t)",
- "SetModuleLoadAddress(lldb::SBModule, uint64_t)")
+ LLDB_DEPRECATED_FIXME("Use SetModuleLoadAddress(lldb::SBModule, uint64_t)",
+ "SetModuleLoadAddress(lldb::SBModule, uint64_t)")
lldb::SBError SetModuleLoadAddress(lldb::SBModule module,
int64_t sections_offset);
#endif
Index: lldb/include/lldb/API/SBStructuredData.h
===================================================================
--- lldb/include/lldb/API/SBStructuredData.h
+++ lldb/include/lldb/API/SBStructuredData.h
@@ -72,8 +72,9 @@
/// Return the integer value if this data structure is an integer type.
int64_t GetSignedIntegerValue(int64_t fail_value = 0) const;
- LLDB_DEPRECATED("Specify if the value is signed or unsigned",
- "uint64_t GetUnsignedIntegerValue(uint64_t fail_value = 0)")
+ LLDB_DEPRECATED_FIXME(
+ "Specify if the value is signed or unsigned",
+ "uint64_t GetUnsignedIntegerValue(uint64_t fail_value = 0)")
uint64_t GetIntegerValue(uint64_t fail_value = 0) const;
/// Return the floating point value if this data structure is a floating
Index: lldb/include/lldb/API/SBProcess.h
===================================================================
--- lldb/include/lldb/API/SBProcess.h
+++ lldb/include/lldb/API/SBProcess.h
@@ -48,7 +48,7 @@
const char *GetPluginName();
- LLDB_DEPRECATED("Use GetPluginName()", "GetPluginName()")
+ LLDB_DEPRECATED_FIXME("Use GetPluginName()", "GetPluginName()")
const char *GetShortPluginName();
void Clear();
Index: lldb/include/lldb/API/SBFileSpec.h
===================================================================
--- lldb/include/lldb/API/SBFileSpec.h
+++ lldb/include/lldb/API/SBFileSpec.h
@@ -19,9 +19,10 @@
SBFileSpec(const lldb::SBFileSpec &rhs);
- LLDB_DEPRECATED("Use the other constructor to determine if this the file "
- "spec should be resolved",
- "SBFileSpec(const char *, bool)")
+ LLDB_DEPRECATED_FIXME(
+ "Use the other constructor to determine if this the file "
+ "spec should be resolved",
+ "SBFileSpec(const char *, bool)")
SBFileSpec(const char *path);
SBFileSpec(const char *path, bool resolve);
Index: lldb/include/lldb/API/SBDefines.h
===================================================================
--- lldb/include/lldb/API/SBDefines.h
+++ lldb/include/lldb/API/SBDefines.h
@@ -34,7 +34,9 @@
// supports the attribute.
#if defined(SWIG) || _cplusplus < 201402L
#undef LLDB_DEPRECATED
-#define LLDB_DEPRECATED(MSG, FIX)
+#undef LLDB_DEPRECATED_FIXME
+#define LLDB_DEPRECATED(MSG)
+#define LLDB_DEPRECATED_FIXME(MSG, FIX)
#endif
// Forward Declarations
Index: lldb/include/lldb/API/SBDebugger.h
===================================================================
--- lldb/include/lldb/API/SBDebugger.h
+++ lldb/include/lldb/API/SBDebugger.h
@@ -115,7 +115,7 @@
static void Terminate();
- LLDB_DEPRECATED("Use one of the other Create variants", "Create(bool)")
+ LLDB_DEPRECATED_FIXME("Use one of the other Create variants", "Create(bool)")
static lldb::SBDebugger Create();
static lldb::SBDebugger Create(bool source_init_files);
@@ -208,14 +208,13 @@
lldb::SBListener GetListener();
#ifndef SWIG
- LLDB_DEPRECATED(
+ LLDB_DEPRECATED_FIXME(
"Use HandleProcessEvent(const SBProcess &, const SBEvent &, SBFile, "
"SBFile) or HandleProcessEvent(const SBProcess &, const SBEvent &, "
"FileSP, FileSP)",
"HandleProcessEvent(const SBProcess &, const SBEvent &, SBFile, SBFile)")
void HandleProcessEvent(const lldb::SBProcess &process,
- const lldb::SBEvent &event, FILE *out,
- FILE *err);
+ const lldb::SBEvent &event, FILE *out, FILE *err);
#endif
void HandleProcessEvent(const lldb::SBProcess &process,
@@ -332,8 +331,8 @@
void *baton);
#ifndef SWIG
- LLDB_DEPRECATED("Use DispatchInput(const void *, size_t)",
- "DispatchInput(const void *, size_t)")
+ LLDB_DEPRECATED_FIXME("Use DispatchInput(const void *, size_t)",
+ "DispatchInput(const void *, size_t)")
void DispatchInput(void *baton, const void *data, size_t data_len);
#endif
Index: lldb/include/lldb/API/SBCommandReturnObject.h
===================================================================
--- lldb/include/lldb/API/SBCommandReturnObject.h
+++ lldb/include/lldb/API/SBCommandReturnObject.h
@@ -47,8 +47,8 @@
const char *GetError();
#ifndef SWIG
- LLDB_DEPRECATED("Use PutOutput(SBFile) or PutOutput(FileSP)",
- "PutOutput(SBFile)")
+ LLDB_DEPRECATED_FIXME("Use PutOutput(SBFile) or PutOutput(FileSP)",
+ "PutOutput(SBFile)")
size_t PutOutput(FILE *fh);
#endif
@@ -61,8 +61,8 @@
size_t GetErrorSize();
#ifndef SWIG
- LLDB_DEPRECATED("Use PutError(SBFile) or PutError(FileSP)",
- "PutError(SBFile)")
+ LLDB_DEPRECATED_FIXME("Use PutError(SBFile) or PutError(FileSP)",
+ "PutError(SBFile)")
size_t PutError(FILE *fh);
#endif
@@ -87,22 +87,22 @@
bool GetDescription(lldb::SBStream &description);
#ifndef SWIG
- LLDB_DEPRECATED(
+ LLDB_DEPRECATED_FIXME(
"Use SetImmediateOutputFile(SBFile) or SetImmediateOutputFile(FileSP)",
"SetImmediateOutputFile(SBFile)")
void SetImmediateOutputFile(FILE *fh);
- LLDB_DEPRECATED(
+ LLDB_DEPRECATED_FIXME(
"Use SetImmediateErrorFile(SBFile) or SetImmediateErrorFile(FileSP)",
"SetImmediateErrorFile(SBFile)")
void SetImmediateErrorFile(FILE *fh);
- LLDB_DEPRECATED(
+ LLDB_DEPRECATED_FIXME(
"Use SetImmediateOutputFile(SBFile) or SetImmediateOutputFile(FileSP)",
"SetImmediateOutputFile(SBFile)")
void SetImmediateOutputFile(FILE *fh, bool transfer_ownership);
- LLDB_DEPRECATED(
+ LLDB_DEPRECATED_FIXME(
"Use SetImmediateErrorFile(SBFile) or SetImmediateErrorFile(FileSP)",
"SetImmediateErrorFile(SBFile)")
void SetImmediateErrorFile(FILE *fh, bool transfer_ownership);
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
