bulbazord added a comment.

Making `m_lock_count`'s type into `std::atomic<uint32_t>` makes sense to me, 
but I'm a little confused about why `Process::LoadOperatingSystemPlugin` is 
guarded by acquiring `m_thread_mutex`. My (admittedly limited) understanding of 
that is that it's a mutex that the Process holds for the ThreadList to manage 
concurrent modifications to the thread list. Is loading an Operating System 
plugin related to modifying the ThreadList? If not, perhaps it would be better 
served by having its own mutex?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154271/new/

https://reviews.llvm.org/D154271

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to