bulbazord added inline comments.
================
Comment at: lldb/include/lldb/API/SBValue.h:286
+ LLDB_DEPRECATED("SBValue::GetOpaqueType() is deprecated. Do not use.", "")
void *GetOpaqueType();
----------------
mib wrote:
> JDevlieghere wrote:
> > Similar comment as in D153900: The "Do not use." part is redundant and
> > implied by the deprecation.
> Should we add a macro like for `LLDB_INVALID_*` to act as the `FIX` argument
> ? It feels wrong to pass an empty string.
Yeah, I think it would be useful to distinguish between deprecations for "we
have a better way to do this now" and "we probably shouldn't be exposing this
method". I'll submit a separate change for that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153918/new/
https://reviews.llvm.org/D153918
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
