bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, mib.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
No need to create a ConstString, `GetName` already returns a StringRef.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D154386
Files:
lldb/source/Interpreter/OptionValue.cpp
Index: lldb/source/Interpreter/OptionValue.cpp
===================================================================
--- lldb/source/Interpreter/OptionValue.cpp
+++ lldb/source/Interpreter/OptionValue.cpp
@@ -534,8 +534,8 @@
if (m_parent_sp->DumpQualifiedName(strm))
dumped_something = true;
}
- ConstString name(GetName());
- if (name) {
+ llvm::StringRef name(GetName());
+ if (!name.empty()) {
if (dumped_something)
strm.PutChar('.');
else
Index: lldb/source/Interpreter/OptionValue.cpp
===================================================================
--- lldb/source/Interpreter/OptionValue.cpp
+++ lldb/source/Interpreter/OptionValue.cpp
@@ -534,8 +534,8 @@
if (m_parent_sp->DumpQualifiedName(strm))
dumped_something = true;
}
- ConstString name(GetName());
- if (name) {
+ llvm::StringRef name(GetName());
+ if (!name.empty()) {
if (dumped_something)
strm.PutChar('.');
else
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
