This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7ed3c2edf017: [lldb] Increase the maximum number of classes
we can read from shared cache (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153817/new/
https://reviews.llvm.org/D153817
Files:
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Index:
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
===================================================================
---
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
+++
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
@@ -2308,7 +2308,10 @@
// The number of entries to pre-allocate room for.
// Each entry is (addrsize + 4) bytes
- const uint32_t max_num_classes = 163840;
+ // FIXME: It is not sustainable to continue incrementing this value every
time
+ // the shared cache grows. This is because it requires allocating memory in
+ // the inferior process and some inferior processes have small memory limits.
+ const uint32_t max_num_classes = 212992;
UtilityFunction *get_class_info_code = GetClassInfoUtilityFunction(exe_ctx);
if (!get_class_info_code) {
Index: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
===================================================================
--- lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
+++ lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
@@ -2308,7 +2308,10 @@
// The number of entries to pre-allocate room for.
// Each entry is (addrsize + 4) bytes
- const uint32_t max_num_classes = 163840;
+ // FIXME: It is not sustainable to continue incrementing this value every time
+ // the shared cache grows. This is because it requires allocating memory in
+ // the inferior process and some inferior processes have small memory limits.
+ const uint32_t max_num_classes = 212992;
UtilityFunction *get_class_info_code = GetClassInfoUtilityFunction(exe_ctx);
if (!get_class_info_code) {
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
