bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, jasonmolenda, jingham, kastiglione.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
The shared cache has grown past the previously hardcoded limit. As a
temporary measure, I am increasing the hardcoded number of classes we
can expect to read from the shared cache. This is not a good long-term
solution.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D153817
Files:
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Index:
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
===================================================================
---
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
+++
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
@@ -2308,7 +2308,9 @@
// The number of entries to pre-allocate room for.
// Each entry is (addrsize + 4) bytes
- const uint32_t max_num_classes = 163840;
+ // FIXME: It is not sustainable to continue incrementing this value every
time
+ // the shared cache grows.
+ const uint32_t max_num_classes = 200000;
UtilityFunction *get_class_info_code = GetClassInfoUtilityFunction(exe_ctx);
if (!get_class_info_code) {
Index: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
===================================================================
--- lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
+++ lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
@@ -2308,7 +2308,9 @@
// The number of entries to pre-allocate room for.
// Each entry is (addrsize + 4) bytes
- const uint32_t max_num_classes = 163840;
+ // FIXME: It is not sustainable to continue incrementing this value every time
+ // the shared cache grows.
+ const uint32_t max_num_classes = 200000;
UtilityFunction *get_class_info_code = GetClassInfoUtilityFunction(exe_ctx);
if (!get_class_info_code) {
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
