[jira] [Commented] (MSHARED-831) Configuration in reporting section not taken into account when running from cli

2022-05-29 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543574#comment-17543574 ] Herve Boutemy commented on MSHARED-831: --- it would be useful to have feedback on us

[jira] [Updated] (DOXIA-651) Upgrade Flexmark to 0.50.50

2022-05-29 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated DOXIA-651: Description: Changed classes: https://github.com/vsch/flexmark-java/blob/master/assets/migrations/m

[GitHub] [maven-doxia] hboutemy commented on pull request #98: [DOXIA-590] Either provided element class or default class gets ignored

2022-05-29 Thread GitBox
hboutemy commented on PR #98: URL: https://github.com/apache/maven-doxia/pull/98#issuecomment-1140401901 IIUC, currently BaseSink *replaces* the class attribute value with its own a or b, it should *append*? -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (DOXIA-590) Either provided element class or default class gets ignored

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543586#comment-17543586 ] ASF GitHub Bot commented on DOXIA-590: -- hboutemy commented on PR #98: URL: https://gi

[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare

2022-05-29 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543589#comment-17543589 ] Herve Boutemy commented on MRELEASE-1072: - we used that svn release support fo

[GitHub] [maven] michael-o commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages

2022-05-29 Thread GitBox
michael-o commented on code in PR #746: URL: https://github.com/apache/maven/pull/746#discussion_r884234997 ## maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java: ## @@ -0,0 +1,91 @@ +package org.apache.maven.internal; + +/* + * Licensed to the Apache

[GitHub] [maven] michael-o commented on pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages

2022-05-29 Thread GitBox
michael-o commented on PR #746: URL: https://github.com/apache/maven/pull/746#issuecomment-1140405016 From my PoV this is now done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543593#comment-17543593 ] ASF GitHub Bot commented on MNG-7486: - michael-o commented on PR #746: URL: https://git

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543592#comment-17543592 ] ASF GitHub Bot commented on MNG-7486: - michael-o commented on code in PR #746: URL: htt

[GitHub] [maven-doxia] michael-o commented on pull request #98: [DOXIA-590] Either provided element class or default class gets ignored

2022-05-29 Thread GitBox
michael-o commented on PR #98: URL: https://github.com/apache/maven-doxia/pull/98#issuecomment-1140406686 > IIUC, currently BaseSink _replaces_ the class attribute value with its own a or b, it should _append_? I think a well named method could make sense Yes, it blindly replaces inst

[jira] [Commented] (DOXIA-590) Either provided element class or default class gets ignored

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543599#comment-17543599 ] ASF GitHub Bot commented on DOXIA-590: -- michael-o commented on PR #98: URL: https://g

[GitHub] [maven-doxia] asfgit merged pull request #102: [DOXIA-652] Drop build-info.properties in favor of default pom.proper…

2022-05-29 Thread GitBox
asfgit merged PR #102: URL: https://github.com/apache/maven-doxia/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apac

[jira] [Commented] (DOXIA-652) Drop build-info.properties in favor of default pom.properties

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543602#comment-17543602 ] ASF GitHub Bot commented on DOXIA-652: -- asfgit merged PR #102: URL: https://github.co

[jira] [Closed] (DOXIA-652) Drop build-info.properties in favor of default pom.properties

2022-05-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-652. Resolution: Fixed Fixed with [74bfa2a315617425c1786373c913a570a7297105|https://gitbox.apache.org/re

[GitHub] [maven-doxia] asfgit closed pull request #101: [DOXIA-651] Upgrade Flexmark to 0.50.50

2022-05-29 Thread GitBox
asfgit closed pull request #101: [DOXIA-651] Upgrade Flexmark to 0.50.50 URL: https://github.com/apache/maven-doxia/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (DOXIA-651) Upgrade Flexmark to 0.50.50

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543605#comment-17543605 ] ASF GitHub Bot commented on DOXIA-651: -- asfgit closed pull request #101: [DOXIA-651]

[jira] [Closed] (DOXIA-651) Upgrade Flexmark to 0.50.50

2022-05-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-651. Resolution: Fixed Fixed with [5508c6962434e9829ef36938e4a2a03290e3917d|https://gitbox.apache.org/re

[jira] [Commented] (MRELEASE-1072) scm.tag removed for next snapshot during prepare

2022-05-29 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543606#comment-17543606 ] Konrad Windszus commented on MRELEASE-1072: --- I am not sure this is a regress

[jira] [Updated] (MRELEASE-1097) clarify goal vs phase terms in output and documentation

2022-05-29 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MRELEASE-1097: Description: {noformat}$ mvn release:prepare -DdryRun [INFO] Scanning for projects... [I

[jira] [Created] (MRELEASE-1097) clarify goal vs phase terms in output and documentation

2022-05-29 Thread Herve Boutemy (Jira)
Herve Boutemy created MRELEASE-1097: --- Summary: clarify goal vs phase terms in output and documentation Key: MRELEASE-1097 URL: https://issues.apache.org/jira/browse/MRELEASE-1097 Project: Maven Relea

[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

2022-05-29 Thread GitBox
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1140416016 > > The Conventional Commits part has specific configuration. That "next version calculator" is a plugin for the maven-release plugin. > > I know see, it is not a plugin in

[GitHub] [maven] mthmulders commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages

2022-05-29 Thread GitBox
mthmulders commented on code in PR #746: URL: https://github.com/apache/maven/pull/746#discussion_r884245248 ## maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java: ## @@ -0,0 +1,91 @@ +package org.apache.maven.internal; + +/* + * Licensed to the Apach

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543609#comment-17543609 ] ASF GitHub Bot commented on MNG-7486: - mthmulders commented on code in PR #746: URL: ht

[GitHub] [maven] michael-o commented on a diff in pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages

2022-05-29 Thread GitBox
michael-o commented on code in PR #746: URL: https://github.com/apache/maven/pull/746#discussion_r884245787 ## maven-core/src/main/java/org/apache/maven/internal/MultilineMessageHelper.java: ## @@ -0,0 +1,91 @@ +package org.apache.maven.internal; + +/* + * Licensed to the Apache

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543610#comment-17543610 ] ASF GitHub Bot commented on MNG-7486: - michael-o commented on code in PR #746: URL: htt

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #154: [MENFORCER-419] Upgrade Maven to 3.2.5

2022-05-29 Thread GitBox
slawekjaranowski opened a new pull request, #154: URL: https://github.com/apache/maven-enforcer/pull/154 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER)

[GitHub] [maven-release] michael-o commented on pull request #104: [MRELEASE-1078] Conventional commits

2022-05-29 Thread GitBox
michael-o commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1140429209 There is an option to inject an `Xpp3Dom` object into the plugin config which in turn could be passed to your class. -- This is an automated message from the Apache Git Service. T

[GitHub] [maven] asfgit merged pull request #746: [MNG-7486] Create a multiline message helper for boxed log messages

2022-05-29 Thread GitBox
asfgit merged PR #746: URL: https://github.com/apache/maven/pull/746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543625#comment-17543625 ] ASF GitHub Bot commented on MNG-7486: - asfgit merged PR #746: URL: https://github.com/a

[jira] [Commented] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

2022-05-29 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543626#comment-17543626 ] Alexander Kriegisch commented on MRELEASE-899: -- I have lobbied for this to

[jira] [Comment Edited] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

2022-05-29 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543626#comment-17543626 ] Alexander Kriegisch edited comment on MRELEASE-899 at 5/29/22 11:55 AM: -

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543627#comment-17543627 ] Hudson commented on MNG-7486: - Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7486

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543628#comment-17543628 ] Hudson commented on MNG-7486: - Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7486

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543629#comment-17543629 ] Hudson commented on MNG-7486: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-746 #

[jira] [Closed] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7486. --- Resolution: Fixed Fixed with [6767f2500f1d005924ccff27f04350c253858a84|https://gitbox.apache.org/repos

[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

2022-05-29 Thread GitBox
nielsbasjes commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1140438229 > There is an option to inject an `Xpp3Dom` object into the plugin config which in turn could be passed to your class. Cool! Can you please point me towards this option on h

[jira] [Commented] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

2022-05-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543631#comment-17543631 ] Michael Osipov commented on MRELEASE-899: - [~kriegaex], I must admit that the f

[GitHub] [maven-release] michael-o commented on pull request #104: [MRELEASE-1078] Conventional commits

2022-05-29 Thread GitBox
michael-o commented on PR #104: URL: https://github.com/apache/maven-release/pull/104#issuecomment-1140438589 Good question. I don't know an example from the top of my head, but you can search `maven-sources` multirepo for `Xpp3Dom`. I am sure this will do. In Maven Settings we use this tri

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #741: [MNG-7468] Check unsupported plugins parameters in configuration

2022-05-29 Thread GitBox
slawekjaranowski commented on code in PR #741: URL: https://github.com/apache/maven/pull/741#discussion_r882886798 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java: ## @@ -108,4 +122,75 @@ private PluginExecution findPluginExe

[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543632#comment-17543632 ] ASF GitHub Bot commented on MNG-7468: - slawekjaranowski commented on code in PR #741: U

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543633#comment-17543633 ] Hudson commented on MNG-7486: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543634#comment-17543634 ] Hudson commented on MNG-7486: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #

[jira] [Commented] (MNG-7486) Create a multiline message helper for boxed log messages

2022-05-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543635#comment-17543635 ] Hudson commented on MNG-7486: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.

[jira] [Commented] (MENFORCER-420) Reuse getDependenciesToCheck results across rules

2022-05-29 Thread Joseph Walton (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543638#comment-17543638 ] Joseph Walton commented on MENFORCER-420: - That makes sense; adding it to the

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #152: MENFORCER-420: cache dependencies across rules

2022-05-29 Thread GitBox
slawekjaranowski commented on code in PR #152: URL: https://github.com/apache/maven-enforcer/pull/152#discussion_r884274320 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/EnforcerRuleHelper.java: ## @@ -131,4 +132,13 @@ List getComponentList ( String role )

[GitHub] [maven] michael-o commented on a diff in pull request #736: [3.8.x] [MNG-7476] Display a warning when an aggregator mojo locks other mojos executions

2022-05-29 Thread GitBox
michael-o commented on code in PR #736: URL: https://github.com/apache/maven/pull/736#discussion_r884276548 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java: ## @@ -220,20 +223,44 @@ private void execute( MavenSession session, MojoExecution mojo

[jira] [Commented] (MNG-7476) Display a warning when an aggregator mojo is locking other mojo executions

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543642#comment-17543642 ] ASF GitHub Bot commented on MNG-7476: - michael-o commented on code in PR #736: URL: htt

[GitHub] [maven] michael-o commented on pull request #736: [3.8.x] [MNG-7476] Display a warning when an aggregator mojo locks other mojos executions

2022-05-29 Thread GitBox
michael-o commented on PR #736: URL: https://github.com/apache/maven/pull/736#issuecomment-1140458035 Moved message helper to https://github.com/apache/maven/pull/746. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Commented] (MNG-7476) Display a warning when an aggregator mojo is locking other mojo executions

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543646#comment-17543646 ] ASF GitHub Bot commented on MNG-7476: - michael-o commented on PR #736: URL: https://git

[GitHub] [maven-release] hboutemy opened a new pull request, #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy opened a new pull request, #135: URL: https://github.com/apache/maven-release/pull/135 https://issues.apache.org/jira/browse/MRELEASE-1097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884282247 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java: ## @@ -308,9 +309,8 @@ else if ( releaseDescriptor.isBr

[GitHub] [maven] michael-o commented on pull request #736: [3.8.x] [MNG-7476] Display a warning when an aggregator mojo locks other mojos executions

2022-05-29 Thread GitBox
michael-o commented on PR #736: URL: https://github.com/apache/maven/pull/736#issuecomment-1140466025 > > > > @gnodet Can the reproducer be turned into an IT? > > > > > > > > > I suppose. The failure would lead to a deadlock. is there a timeout that can be set in the invoker ?

[jira] [Commented] (MNG-7476) Display a warning when an aggregator mojo is locking other mojo executions

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543651#comment-17543651 ] ASF GitHub Bot commented on MNG-7476: - michael-o commented on PR #736: URL: https://git

[jira] [Updated] (MNG-7433) [REGRESSION] Multiple maven instances working on same source tree can lock each other

2022-05-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7433: Fix Version/s: 3.8.6 3.9.0 4.0.0-alpha-1 4.0.

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884285645 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java: ## @@ -308,9 +309,8 @@ else if ( releaseDescriptor.isBra

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884286659 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java: ## @@ -308,9 +309,8 @@ else if ( releaseDescriptor.isBr

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884286863 ## maven-release-manager/pom.xml: ## @@ -238,9 +238,7 @@ - xpp3-reader Review Comment: No model necessary anym

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884299737 ## maven-release-manager/pom.xml: ## @@ -238,9 +238,7 @@ - xpp3-reader Review Comment: model is useful, ie java

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884299924 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java: ## @@ -560,15 +559,10 @@ private ReleaseDescriptorBuilder loadRe

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300187 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java: ## @@ -560,15 +559,10 @@ private ReleaseDescriptorBuilder loadRe

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300250 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java: ## @@ -592,8 +586,6 @@ protected void clean( AbstractReleaseReque

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300327 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java: ## @@ -616,8 +608,6 @@ public void clean( ReleaseCleanRequest cle

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-05-29 Thread GitBox
cstamas commented on code in PR #182: URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884300349 ## maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java: ## @@ -0,0 +1,113 @@

[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543665#comment-17543665 ] ASF GitHub Bot commented on MRESOLVER-262: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-05-29 Thread GitBox
cstamas commented on PR #182: URL: https://github.com/apache/maven-resolver/pull/182#issuecomment-1140489240 > How does this change the message usage when this type of information is collected by default? I don't quite get the question here... -- This is an automated message from t

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300426 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java: ## @@ -726,7 +732,10 @@ private void logInfo( ReleaseResult resul

[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543666#comment-17543666 ] ASF GitHub Bot commented on MRESOLVER-262: -- cstamas commented on PR #182: URL

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300524 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManagerListener.java: ## @@ -86,16 +86,9 @@ public void goalStart( String goal,

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300591 ## maven-release-manager/pom.xml: ## @@ -238,9 +238,7 @@ - xpp3-reader Review Comment: Alright! -- This is

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300620 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java: ## @@ -560,15 +559,10 @@ private ReleaseDescriptorBuilder loadR

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300638 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java: ## @@ -616,8 +608,6 @@ public void clean( ReleaseCleanRequest cl

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300657 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java: ## @@ -726,7 +732,10 @@ private void logInfo( ReleaseResult resu

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300675 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -199,9 +201,15 @@ private void transform( ReleaseD

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300771 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRunGoalsPhase.java: ## @@ -71,11 +72,12 @@ protected ReleaseResult execute( Rel

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300846 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckoutProjectFromScm.java: ## @@ -270,13 +270,19 @@ public ReleaseResult simulate( Re

[GitHub] [maven-resolver] michael-o commented on pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-05-29 Thread GitBox
michael-o commented on PR #182: URL: https://github.com/apache/maven-resolver/pull/182#issuecomment-1140490337 > > How does this change the message usage when this type of information is collected by default? > > I don't quite get the question here... Stupid typo: memory usage

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884300974 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhase.java: ## @@ -99,7 +101,7 @@ private ReleaseResult runLogic( Releas

[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543667#comment-17543667 ] ASF GitHub Bot commented on MRESOLVER-262: -- michael-o commented on PR #182: U

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-05-29 Thread GitBox
michael-o commented on code in PR #182: URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884301025 ## maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java: ## @@ -44,6 +44,8 @

[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543668#comment-17543668 ] ASF GitHub Bot commented on MRESOLVER-262: -- michael-o commented on code in PR

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-05-29 Thread GitBox
cstamas commented on code in PR #182: URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884300349 ## maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java: ## @@ -0,0 +1,113 @@

[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
hboutemy commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884301129 ## maven-release-plugin/src/site/apt/examples/perform-release.apt.vm: ## @@ -29,7 +29,7 @@ Perform a Release Performing a release runs the following release ph

[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543669#comment-17543669 ] ASF GitHub Bot commented on MRESOLVER-262: -- cstamas commented on code in PR #

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884301513 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRunGoalsPhase.java: ## @@ -71,11 +72,12 @@ protected ReleaseResult execute( Re

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884301575 ## maven-release-plugin/src/site/apt/examples/perform-release.apt.vm: ## @@ -29,7 +29,7 @@ Perform a Release Performing a release runs the following release p

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884282247 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java: ## @@ -308,9 +309,8 @@ else if ( releaseDescriptor.isBr

[jira] [Created] (MRELEASE-1098) Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale() and message bundles

2022-05-29 Thread Michael Osipov (Jira)
Michael Osipov created MRELEASE-1098: Summary: Drop o.a.m.shared.release.env.ReleaseEnvironment.getLocale() and message bundles Key: MRELEASE-1098 URL: https://issues.apache.org/jira/browse/MRELEASE-1098

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884301793 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java: ## @@ -308,9 +309,8 @@ else if ( releaseDescriptor.isBr

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884301848 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhase.java: ## @@ -99,7 +101,7 @@ private ReleaseResult runLogic( Relea

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-05-29 Thread GitBox
cstamas commented on code in PR #182: URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884301868 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java: ## @@ -290,6 +290,33 @@ public final CollectResult c

[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543670#comment-17543670 ] ASF GitHub Bot commented on MRESOLVER-262: -- cstamas commented on code in PR #

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884301967 ## maven-release-plugin/src/it/projects/perform/MRELEASE-818/verify.groovy: ## @@ -20,7 +20,7 @@ File buildLog = new File( basedir, 'build.log' ) assert buildLog

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884302026 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManagerListener.java: ## @@ -86,16 +86,9 @@ public void goalStart( String goal

[GitHub] [maven-release] michael-o commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

2022-05-29 Thread GitBox
michael-o commented on code in PR #135: URL: https://github.com/apache/maven-release/pull/135#discussion_r884302074 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -199,9 +201,15 @@ private void transform( Release

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-05-29 Thread GitBox
cstamas commented on code in PR #182: URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884301868 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java: ## @@ -290,6 +290,33 @@ public final CollectResult c

[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543673#comment-17543673 ] ASF GitHub Bot commented on MRESOLVER-262: -- cstamas commented on code in PR #

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-05-29 Thread GitBox
cstamas commented on code in PR #182: URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884300349 ## maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java: ## @@ -0,0 +1,113 @@

[jira] [Commented] (MRESOLVER-262) Provide contextual data in trace data for collector invoked requests

2022-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543686#comment-17543686 ] ASF GitHub Bot commented on MRESOLVER-262: -- cstamas commented on code in PR #

[GitHub] [maven] michael-o commented on a diff in pull request #736: [3.8.x] [MNG-7476] Display a warning when an aggregator mojo locks other mojos executions

2022-05-29 Thread GitBox
michael-o commented on code in PR #736: URL: https://github.com/apache/maven/pull/736#discussion_r884276548 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java: ## @@ -220,20 +223,44 @@ private void execute( MavenSession session, MojoExecution mojo

[GitHub] [maven-resolver] cstamas commented on pull request #182: [MRESOLVER-262] Provide contextual data in trace during collect

2022-05-29 Thread GitBox
cstamas commented on PR #182: URL: https://github.com/apache/maven-resolver/pull/182#issuecomment-1140492617 > > > How does this change the message usage when this type of information is collected by default? > > > > > > I don't quite get the question here... > > Stupid typ

  1   2   >