hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884300974
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhase.java:
##########
@@ -99,7 +101,7 @@ private ReleaseResult runLogic( ReleaseDescriptor
releaseDescriptor, ReleaseEnvi
{
ReleaseResult result = new ReleaseResult();
- logInfo( result, "Simulating perform goals '" + getGoals(
releaseDescriptor )
+ logInfo( result, "Simulating perform goals '" + buffer().strong(
getGoals( releaseDescriptor ) )
Review Comment:
we're using this style to list every phase that is being run
what goals will be invoked is a very different intent
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhase.java:
##########
@@ -99,7 +101,7 @@ private ReleaseResult runLogic( ReleaseDescriptor
releaseDescriptor, ReleaseEnvi
{
ReleaseResult result = new ReleaseResult();
- logInfo( result, "Simulating perform goals '" + getGoals(
releaseDescriptor )
+ logInfo( result, "Simulating perform goals '" + buffer().strong(
getGoals( releaseDescriptor ) )
Review Comment:
good question...
we're using this style to list every phase that is being run
what goals will be invoked is a very different intent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
