michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884300620
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java:
##########
@@ -560,15 +559,10 @@ private ReleaseDescriptorBuilder
loadReleaseDescriptorBuilder( ReleaseDescriptor
{
try
{
- updateListener( listener, "verify-release-configuration",
PHASE_START );
- ReleaseDescriptorBuilder result = configStore.get().read( builder
);
- updateListener( listener, "verify-release-configuration",
PHASE_END );
- return result;
Review Comment:
Agreed.
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java:
##########
@@ -592,8 +586,6 @@ protected void clean( AbstractReleaseRequest releaseRequest
) throws ReleaseFai
@Override
public void clean( ReleaseCleanRequest cleanRequest ) throws
ReleaseFailureException
{
- updateListener( cleanRequest.getReleaseManagerListener(), "cleanup",
PHASE_START );
Review Comment:
Agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
