[GitHub] [maven-release] hboutemy commented on a diff in pull request #135: [MRELEASE-1097] rework plugin output to clarify goal's phases

[GitBox]

hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884300250


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java:
##########
@@ -592,8 +586,6 @@ protected void clean( AbstractReleaseRequest releaseRequest 
 ) throws ReleaseFai
     @Override
     public void clean( ReleaseCleanRequest cleanRequest ) throws 
ReleaseFailureException
     {
-        updateListener( cleanRequest.getReleaseManagerListener(), "cleanup", 
PHASE_START );

Review Comment:
   same "non phase" message that creates confusion when it looks as a phase



##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java:
##########
@@ -592,8 +586,6 @@ protected void clean( AbstractReleaseRequest releaseRequest 
 ) throws ReleaseFai
     @Override
     public void clean( ReleaseCleanRequest cleanRequest ) throws 
ReleaseFailureException
     {
-        updateListener( cleanRequest.getReleaseManagerListener(), "cleanup", 
PHASE_START );

Review Comment:
   same "non phase" message that creates confusion when it looks like a phase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org