hboutemy commented on code in PR #135:
URL: https://github.com/apache/maven-release/pull/135#discussion_r884300771
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRunGoalsPhase.java:
##########
@@ -71,11 +72,12 @@ protected ReleaseResult execute( ReleaseDescriptor
releaseDescriptor, ReleaseEnv
String goals = getGoals( releaseDescriptor );
if ( !StringUtils.isEmpty( goals ) )
{
- logInfo( result, "Executing goals '" + goals + "'..." );
- if ( logArguments && ( additionalArguments != null ) )
+ logInfo( result, "Executing goals '" + buffer().strong( goals
) + "'..." );
+ if ( logArguments )
{
// logging arguments may log secrets: should be activated
only on dryRun
- logInfo( result, " with additional arguments: " +
additionalArguments );
+ logInfo( result, " with additional arguments: "
+ + ( additionalArguments == null ? "" :
additionalArguments ) );
Review Comment:
yes, not seeing that additional arguments were taken into account but were
empty was confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
