[ 
https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543668#comment-17543668
 ] 

ASF GitHub Bot commented on MRESOLVER-262:
------------------------------------------

michael-o commented on code in PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#discussion_r884301025


##########
maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ReverseTreeRepositoryListener.java:
##########
@@ -44,6 +44,8 @@
 public class ReverseTreeRepositoryListener
         extends AbstractRepositoryListener
 {
+    private static final String LINE_SEP = System.lineSeparator();

Review Comment:
   In most cases we even use `LS` or `EOL`.





> Provide contextual data in trace data for collector invoked requests
> --------------------------------------------------------------------
>
>                 Key: MRESOLVER-262
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-262
>             Project: Maven Resolver
>          Issue Type: Task
>          Components: Resolver
>            Reporter: Tamás Cservenák
>            Priority: Major
>             Fix For: 1.8.1
>
>
> During collection several RepositoryEvents are fired, but they does not carry 
> any context related data regarding artifact collection.
> Simplest solution would be to extend RequestTrace to provide:
>  * request context
>  * the artifact path (from root to leaf)
>  * leaf artifact being collected



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to