[
https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543626#comment-17543626
]
Alexander Kriegisch commented on MRELEASE-899:
----------------------------------------------
I have lobbied for this to be implemented, so I also want to thank you for the
implementation. I have not actually build a snapshot and tried for myself, but
the commit looks good to me. I would have preferred auto-detect to be the
default mode, but I can live with the new user option and understand that you
want to retain backward compatibility, rather seeing the previous behaviour as
a feature rather than a bug like me.
As soon as M6 will become available, I shall be glad to give it a spin and
re-test. Thank you very much again. 👏🙂
> release:prepare should not change the line separator but detect effective
> line separator from pom.xml
> -----------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-899
> URL: https://issues.apache.org/jira/browse/MRELEASE-899
> Project: Maven Release Plugin
> Issue Type: New Feature
> Reporter: Ralph van Etten
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.0.0-M6
>
>
> Currently the plugin use the system property {{line.separator}} when it
> rewrites the pom.xml.
> This causes trouble, because every line in changed, when a project is
> released sometimes under Windows and sometimes under Linux (because of its
> different line separators).
> (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the
> systems line separator but the line separator that is already used in the
> pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm
> someone else.
> Therefore it would be an great feature when there would be an property that
> define the expected behaviour, maybe in the same way it is done by the
> maven-assembly-plugin's property fileSet.lineEnding
> (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
