cstamas commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1926632787
Looks good! Sorry to be late to party, but we can improve all this "on the
go" anyway...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
gnodet merged PR #1391:
URL: https://github.com/apache/maven/pull/1391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
desruisseaux commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1477063891
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyScope.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
desruisseaux commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1477061773
##
api/maven-api-core/src/main/java/org/apache/maven/api/ExtensibleEnum.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1477061460
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyScope.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1477061342
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyScope.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
desruisseaux commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1477061283
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyScope.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
desruisseaux commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1477061174
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyScope.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
desruisseaux commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1477061030
##
api/maven-api-core/src/main/java/org/apache/maven/api/DependencyScope.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
gnodet commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1920108675
@cstamas I've removed `BuildPath` which will be provided by #1378 (inside
`DependencyResolverResult`) and renamed `BuildPathScope` to `PathScope` to
align with the other PR which defines `Pa
cstamas merged PR #1392:
URL: https://github.com/apache/maven/pull/1392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466386770
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1910193302
First "block" or "step" is here https://github.com/apache/maven/pull/1392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
cstamas commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1910189997
Just a general remark: Am fine if we "redefine" here everything, from ground
up, but IMHO "safest" would be to go "resolver way" (adhere to its abstractions
closest as possible) as it is pr
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466313211
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466313211
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466288875
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
rmannibucau commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466226764
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466221747
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466213690
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466207334
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
rmannibucau commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466206736
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466200346
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas opened a new pull request, #1392:
URL: https://github.com/apache/maven/pull/1392
Maven should be fully in control regarding dependency scope definitions and
their interpretations (and transformations).
This PR makes following changes:
* no change in behaviour (all works as bef
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466200346
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
rmannibucau commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1909909961
I'm more than fine doing it by "blocks" - in particular the last part Tamas
explained - but how can we ensure we don't get this PR without next one in
terms of release to avoid to expos
cstamas commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1909896797
> Maybe, but there's no point in the first PR if we don't go further...
Um, the point of first commit is to move off from all the deprecated classes
in resolver (see https://github.co
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466175527
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466175527
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
gnodet commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1909864873
> @gnodet and this is why I think that "step 1" should have been merged.
This discussion will take some, and this PR will just potentially drift away
from master (unless we freeze master, wh
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466167884
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466156908
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466156908
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466149072
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1909793144
@gnodet and this is why I think that "step 1" should have been merged. This
discussion will take some, and this PR will just potentially drift away from
master (unless we freeze master, whi
cstamas commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1909785670
> I also find the term `build path` somewhat misleading...
Am completely fine to keep "resolution path" as well, but did not want to
disturb existing classes...
--
This is an autom
gnodet commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1909448765
> @cstamas does it mean we should fix the naming for mvn 4 and align it on
what it is? Resolverpaths or alike since it is unrelated to any actual build
and becomes even more ambiguous with j
rmannibucau commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1909427969
@cstamas does it mean we should fix the naming for mvn 4 and align it on
what it is? Resolverpaths or alike since it is unrelated to any actual build
and becomes even more ambiguous wit
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1465554808
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1908946500
It was always "build path" but Maven internally called it wrongly
"classpath" :wink:
Basically what we do here is laying down new API blocks for dep scopes and
build path scopes.
rmannibucau commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1908933445
@cstamas I see the 1-1 with what exists but I have some hard time - blame
the hour maybe ;) - to see how we can make it consistent with the type work
which is pending, typically build p
cstamas commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1908920207
There is one maven-core UT failing as DefaultPackagingManager seems not set
somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1465541701
##
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultArtifact.java:
##
@@ -95,7 +97,12 @@ public String getClassifier() {
@Override
public boolea
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1465540157
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1465540157
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+/**
+
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1465533187
##
api/maven-api-core/src/main/java/org/apache/maven/api/Packaging.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1465532360
##
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultArtifact.java:
##
@@ -95,7 +97,12 @@ public String getClassifier() {
@Override
public boolean
cstamas commented on PR #1391:
URL: https://github.com/apache/maven/pull/1391#issuecomment-1908578674
The most important: `project + buildPathScope == buildPath` but `buildPath`
is not done fully (just there as placeholder).
--
This is an automated message from the Apache Git Service.
To
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1464865561
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/scopes/MavenDependencyScopes.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Softwa
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1464865561
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/scopes/MavenDependencyScopes.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Softwa
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1464864632
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java:
##
@@ -49,7 +49,9 @@
* assist those clients that employ t
cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1464863514
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/scopes/MavenDependencyScopes.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Softwa
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1464861777
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java:
##
@@ -49,7 +49,9 @@
* assist those clients that employ th
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1464831692
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/scopes/MavenDependencyScopes.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Softwar
gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1464830997
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/scopes/MavenDependencyScopes.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Softwar
cstamas opened a new pull request, #1391:
URL: https://github.com/apache/maven/pull/1391
This is step one: basically moved (copied, as resolver bits are deprecated)
all the classes dealing with scopes (and their interpretation) to Maven.
---
https://issues.apache.org/jira/brows
56 matches
Mail list logo
