cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466149072


##########
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##########
@@ -105,6 +105,14 @@ default String key() {
      */
     boolean isSnapshot();
 
+    /**
+     * The artifact properties.
+     *
+     * @return the artifact properties, never {@code null}
+     */
+    @Nonnull
+    ArtifactProperties getArtifactProperties();

Review Comment:
   I disagree here: Dependency is what you have in POMs (either project or 
transitive deps). So, when you resolve, you end up with bunch of `Artifact`s, 
NOT `Dependency`ies. Basically, that is why this is needed on `Artifact` and 
not `Dependency` (where is also needed, as properties from type should and 
could be still augmented).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to