cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1465541701
##########
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultArtifact.java:
##########
@@ -95,7 +97,12 @@ public String getClassifier() {
@Override
public boolean isSnapshot() {
- return DefaultModelVersionParser.checkSnapshot(artifact.getVersion());
+ return artifact.isSnapshot();
Review Comment:
Agreed.
My point is to have one "source of truth". So if we change this once, we
change that one spot. Currently, resolver Artifact.isSnapshot should be it
IMHO. But agree, let's move it out from this PR, does not belong here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
