gnodet commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466167884
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##########
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+ /**
+ * The artifact properties.
+ *
+ * @return the artifact properties, never {@code null}
+ */
+ @Nonnull
+ ArtifactProperties getArtifactProperties();
Review Comment:
> Or in other words: see this PR
[apache/maven-resolver#411](https://github.com/apache/maven-resolver/pull/411)
Basically Resolver can be now asked to:
>
> * create Artifact as `new Artifact("g:a:v",
artifactTypeRegistry.get("annotation-processor"))`.
> * the to resolve it to have it's full transitive hull
> * and you again end up with "bunch of Artifacts"
>
> No dependency in scope, but you are STILL interested in Artifact
properties....
I don't think that's right. You're looking at the resolver API, not the
Maven API here.
> Or similarly for ANY artifact, as if artifact you are resolving may have
type="modular-jar", then the needed info will be still present in
artifact.properties. Again, no dependencies involved, etc.
There's no `Type` on the `Artifact` ...
> Am pretty much confident that this change is correct.
I think it maps to the resolver api and model, but definitely not to the
Maven 4 API, which as `Artifact`, `ArtifactCoordinate`, `Dependency` and
`DependencyCoordinate`, whereas resolver as `Artifact` only...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
