cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1464864632


##########
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java:
##########
@@ -49,7 +49,9 @@
  * assist those clients that employ the repository system outside of an IoC 
container, Maven plugins should instead
  * always use regular dependency injection to acquire the repository system.
  *
+ * @deprecated See {@link MavenSessionBuilderSupplier}
  */
+@Deprecated
 public final class MavenRepositorySystemUtils {

Review Comment:
   These are all static methods, IMHO nope. 
   
   This class would be used only by some third party integration, but given 
current Maven4 is still alpha, I am more for dropping this class and use 
MavenSessionBuilderSupplier instead, in those apps that integrate Maven4. For 
those apps, the "price" for moving from Resolver1/Maven3 to Resolver2/Maven4 
would be this change. Or they should just use MIMA :smile: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to