cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466156908
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##########
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+ /**
+ * The artifact properties.
+ *
+ * @return the artifact properties, never {@code null}
+ */
+ @Nonnull
+ ArtifactProperties getArtifactProperties();
Review Comment:
Or in other words: see this PR
https://github.com/apache/maven-resolver/pull/411
Basically Resolver can be now asked to:
* create Artifact as `new Artifact("g:a:v",
artifactTypeRegistry.get("annotation-processor"))`. (and this ctor is not new,
in a way, you could do the same even with existing ctors, this was just a
shorthand to make possible to use type with string "coords").
* the to resolve it to have it's full transitive hull
* and you again end up with "bunch of Artifacts", but you still want to sift
thru them, filter them by properties
No dependency in scope, but you are STILL interested in Artifact
properties....
Or similarly for ANY artifact, as if artifact you are resolving may have
type="modular-jar", then the needed info will be still present in
artifact.properties. Again, no dependencies involved, etc.
Am pretty much confident that this change is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
