cstamas commented on code in PR #1391:
URL: https://github.com/apache/maven/pull/1391#discussion_r1466175527
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##########
@@ -105,6 +105,14 @@ default String key() {
*/
boolean isSnapshot();
+ /**
+ * The artifact properties.
+ *
+ * @return the artifact properties, never {@code null}
+ */
+ @Nonnull
+ ArtifactProperties getArtifactProperties();
Review Comment:
No, `Type` is a property of `Dependency`. What happens is that is just an
indirection of `Type` -> `properties`. If you think about, EVERY Artifact (sans
root) have type (as they enter scope as dependencies of root).
And yes, am looking at Resolver API as it is done well and works. IMO we
should really just pull a thin layer on top of it for start, that we can refine
later. But in general, this is how things should work, really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
