[jira] [Commented] (MNG-7391) add MojoExecution strategy and runner required by Maven Build Cache Extension

2022-03-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506734#comment-17506734 ] Hudson commented on MNG-7391: - Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.9

[jira] [Commented] (MNG-7391) add MojoExecution strategy and runner required by Maven Build Cache Extension

2022-03-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506719#comment-17506719 ] Hudson commented on MNG-7391: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #

[GitHub] [maven] laeubi commented on pull request #692: [MNG-7391] Fix MojosExecutionStrategy lookup to be able to look into the SessionScope

2022-03-14 Thread GitBox
laeubi commented on pull request #692: URL: https://github.com/apache/maven/pull/692#issuecomment-1067604948 Alright, I forget about this :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] gnodet commented on pull request #692: [MNG-7391] Fix MojosExecutionStrategy lookup to be able to look into the SessionScope

2022-03-14 Thread GitBox
gnodet commented on pull request #692: URL: https://github.com/apache/maven/pull/692#issuecomment-1067604505 @laeubi the MojosExecutionStrategy has been introduced in 3.9.x and 4.0.x, but it's not present in 3.8.x branch. -- This is an automated message from the Apache Git Service. To re

[GitHub] [maven] laeubi commented on pull request #692: [MNG-7391] Fix MojosExecutionStrategy lookup to be able to look into the SessionScope

2022-03-14 Thread GitBox
laeubi commented on pull request #692: URL: https://github.com/apache/maven/pull/692#issuecomment-1067599376 @gnodet @michael-o just wondering, would this maybe a good candidate for a maven-3.8.6 or are there no bug-fix releases for maven? -- This is an automated message from the Apache

[GitHub] [maven-verifier] kwin commented on a change in pull request #12: Test Embedded3xLauncher with Maven Home

2022-03-14 Thread GitBox
kwin commented on a change in pull request #12: URL: https://github.com/apache/maven-verifier/pull/12#discussion_r826605677 ## File path: src/test/java/org/apache/maven/it/Embedded3xLauncherTest.java ## @@ -19,8 +19,7 @@ * under the License. */ -import static org.hamcrest

[GitHub] [maven] gnodet merged pull request #693: [MNG-7391] Fix MojosExecutionStrategy lookup to be able to look into the SessionScope

2022-03-14 Thread GitBox
gnodet merged pull request #693: URL: https://github.com/apache/maven/pull/693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [maven] gnodet merged pull request #692: [MNG-7391] Fix MojosExecutionStrategy lookup to be able to look into the SessionScope

2022-03-14 Thread GitBox
gnodet merged pull request #692: URL: https://github.com/apache/maven/pull/692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request #76: Bump maven-plugins from 34 to 35

2022-03-14 Thread GitBox
dependabot[bot] opened a new pull request #76: URL: https://github.com/apache/maven-site-plugin/pull/76 Bumps [maven-plugins](https://github.com/apache/maven-parent) from 34 to 35. Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view

[jira] [Commented] (MSHARED-1044) Required report phase are executed many time in the same Maven session

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506656#comment-17506656 ] Herve Boutemy commented on MSHARED-1044: I found the initial MSITE-650 issue...

[GitHub] [maven-surefire] olamy commented on pull request #488: Surefire Report order results

2022-03-14 Thread GitBox
olamy commented on pull request #488: URL: https://github.com/apache/maven-surefire/pull/488#issuecomment-1067437465 > > Please follow [SUREFIRE-XXX] in commit subject and PR title. > > @slawekjaranowski please read 2nd line of PR description. @nhojpatrick we do have sone auto

[jira] [Commented] (MPOM-303) Rename property maven.plugin.tools.version to mavenPluginToolsVersion

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506636#comment-17506636 ] Herve Boutemy commented on MPOM-303: notice that if we are trying to define a global co

[jira] [Commented] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId

2022-03-14 Thread AO Industries, Inc. (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506635#comment-17506635 ] AO Industries, Inc. commented on MJAVADOC-682: -- We have tested version 3.3

[jira] [Updated] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId

2022-03-14 Thread AO Industries, Inc. (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AO Industries, Inc. updated MJAVADOC-682: - Environment: Debian Linux versions 10.10 through 11.2 OpenJDK 64-bit versions 1

[jira] [Updated] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId

2022-03-14 Thread AO Industries, Inc. (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AO Industries, Inc. updated MJAVADOC-682: - Description: In versions 3.1.0 through 3.3.2, when a reactor build has multiple

[jira] [Updated] (MJAVADOC-682) Reactor builds fail when multiple modules with same groupId:artifactId

2022-03-14 Thread AO Industries, Inc. (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AO Industries, Inc. updated MJAVADOC-682: - Affects Version/s: 3.3.2 > Reactor builds fail when multiple modules with same

[GitHub] [maven-surefire] nhojpatrick edited a comment on pull request #488: Surefire Report order results

2022-03-14 Thread GitBox
nhojpatrick edited a comment on pull request #488: URL: https://github.com/apache/maven-surefire/pull/488#issuecomment-1067401634 > Please follow [SUREFIRE-XXX] in commit subject and PR title. @slawekjaranowski please read 2nd line of PR description. -- This is an automated message

[GitHub] [maven-surefire] nhojpatrick commented on pull request #488: Surefire Report order results

2022-03-14 Thread GitBox
nhojpatrick commented on pull request #488: URL: https://github.com/apache/maven-surefire/pull/488#issuecomment-1067401634 > Please follow [SUREFIRE-XXX] in commit subject and PR title. please read 2nd line of PR description. -- This is an automated message from the Apache Git Serv

[GitHub] [maven-surefire] olamy commented on pull request #488: Surefire Report order results

2022-03-14 Thread GitBox
olamy commented on pull request #488: URL: https://github.com/apache/maven-surefire/pull/488#issuecomment-1067383302 CheckTestNgVersionsIT is failing. I'm not sure if the test is really relevant now with this change. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [maven-verifier] slawekjaranowski commented on pull request #12: Test Embedded3xLauncher with Maven Home

2022-03-14 Thread GitBox
slawekjaranowski commented on pull request #12: URL: https://github.com/apache/maven-verifier/pull/12#issuecomment-1067381684 @kwin - please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-surefire] Tibor17 commented on pull request #490: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

2022-03-14 Thread GitBox
Tibor17 commented on pull request #490: URL: https://github.com/apache/maven-surefire/pull/490#issuecomment-1067368611 @imonteroperez Feel free to participate. See the Git metadata and the git commit message. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [maven-surefire] Tibor17 opened a new pull request #490: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

2022-03-14 Thread GitBox
Tibor17 opened a new pull request #490: URL: https://github.com/apache/maven-surefire/pull/490 The purpose of this PR is to add the authors. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #488: Surefire Report order results

2022-03-14 Thread GitBox
slawekjaranowski commented on pull request #488: URL: https://github.com/apache/maven-surefire/pull/488#issuecomment-1067326984 Please follow [SUREFIRE-XXX] in commit subject and PR title. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [maven-surefire] slawekjaranowski opened a new pull request #489: Stage site on GH actions

2022-03-14 Thread GitBox
slawekjaranowski opened a new pull request #489: URL: https://github.com/apache/maven-surefire/pull/489 According to https://github.com/apache/maven-gh-actions-shared/pull/40 --- Following this checklist to help us incorporate your contribution quickly and easily: -

[jira] [Commented] (MPOM-302) Rename property surefire.version to surefireVersion

2022-03-14 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506490#comment-17506490 ] Slawomir Jaranowski commented on MPOM-302: -- It is ok for me to have properties wit

[jira] [Commented] (MSHARED-1045) MSHARED-1024 breaks binary backwards compatibility

2022-03-14 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506459#comment-17506459 ] Michael Osipov commented on MSHARED-1045: - Do you have an explicit example whic

[jira] [Updated] (MSHARED-1045) MSHARED-1024 breaks binary backwards compatibility

2022-03-14 Thread Andrei Silviu Dragnea (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Silviu Dragnea updated MSHARED-1045: --- Description: [https://github.com/apache/maven-reporting-api/pull/2] breaks

[jira] [Created] (MSHARED-1045) MSHARED-1024 breaks binary backwards compatibility

2022-03-14 Thread Andrei Silviu Dragnea (Jira)
Andrei Silviu Dragnea created MSHARED-1045: -- Summary: MSHARED-1024 breaks binary backwards compatibility Key: MSHARED-1045 URL: https://issues.apache.org/jira/browse/MSHARED-1045 Project: Mave

[jira] [Commented] (MPOM-303) Rename property maven.plugin.tools.version to mavenPluginToolsVersion

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506405#comment-17506405 ] Herve Boutemy commented on MPOM-303: I know we have older mix, both at Apache level and

[jira] [Commented] (MNG-6058) Test dependencies should override application dependencies only during testing

2022-03-14 Thread Joe Barnett (Jira)
[ https://issues.apache.org/jira/browse/MNG-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506372#comment-17506372 ] Joe Barnett commented on MNG-6058: -- see also https://issues.apache.org/jira/browse/MNG-415

[jira] [Commented] (MWRAPPER-23) in maven-wrapper, maven user home is not consistent with maven core

2022-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506355#comment-17506355 ] ASF GitHub Bot commented on MWRAPPER-23: gzm55 commented on pull request #28: UR

[GitHub] [maven-wrapper] gzm55 commented on pull request #28: [MWRAPPER-23] Get maven user home (~/.m2) with the same logic with maven

2022-03-14 Thread GitBox
gzm55 commented on pull request #28: URL: https://github.com/apache/maven-wrapper/pull/28#issuecomment-1067071379 > The "naming" of maven.user.home might or might not be correct, that could be debated, it was borrowed from [gradle](https://docs.gradle.org/current/userguide/directory_layout

[jira] [Commented] (MWRAPPER-23) in maven-wrapper, maven user home is not consistent with maven core

2022-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506332#comment-17506332 ] ASF GitHub Bot commented on MWRAPPER-23: jorsol commented on pull request #28: U

[GitHub] [maven-wrapper] jorsol commented on pull request #28: [MWRAPPER-23] Get maven user home (~/.m2) with the same logic with maven

2022-03-14 Thread GitBox
jorsol commented on pull request #28: URL: https://github.com/apache/maven-wrapper/pull/28#issuecomment-1067038041 > mavenUserHome is more like a maven directory for [user configuration](https://github.com/apache/maven/blob/maven-3.8.5/maven-embedder/src/main/java/org/apache/maven/cli/Maven

[GitHub] [maven] gnodet opened a new pull request #694: Improve classloading

2022-03-14 Thread GitBox
gnodet opened a new pull request #694: URL: https://github.com/apache/maven/pull/694 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the ch

[jira] [Updated] (MRELEASE-1080) Maven 3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-14 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1080: - Fix Version/s: 3.0.0-M6 (was: waiting-for-feedback) > Maven 3.8

[jira] [Assigned] (MRELEASE-1080) Maven 3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-14 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRELEASE-1080: Assignee: Michael Osipov > Maven 3.8.4 exits with non-zero status from release:

[jira] [Commented] (MRELEASE-1080) Maven 3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-14 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506292#comment-17506292 ] Michael Osipov commented on MRELEASE-1080: -- Please create a new JIRA issue to

[GitHub] [maven] gnodet commented on pull request #692: [MNG-7391] Fix MojosExecutionStrategy lookup to be able to look into the SessionScope

2022-03-14 Thread GitBox
gnodet commented on pull request #692: URL: https://github.com/apache/maven/pull/692#issuecomment-1066931175 The component is cached by its scope. When `m-build-cache-e` is not active, it's `@Singleton` and when it's active, it's the `@SessionScope`. In both cases, that's fine, as the bu

[GitHub] [maven-resolver] michael-o commented on pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout

2022-03-14 Thread GitBox
michael-o commented on pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#issuecomment-1066921491 > IMO, as we still test with `endsWith`, dotless and dotted is important, but for simplicity sake, we'd maybe enforce configuration to use only dotted (dot prefixed) inp

[GitHub] [maven-resolver] michael-o commented on a change in pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout

2022-03-14 Thread GitBox
michael-o commented on a change in pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#discussion_r826056881 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/Maven2RepositoryLayoutFactory.java ## @@ -128,6 +129,18 @@ public

[GitHub] [maven] laeubi commented on pull request #692: [MNG-7391] Fix MojosExecutionStrategy lookup to be able to look into the SessionScope

2022-03-14 Thread GitBox
laeubi commented on pull request #692: URL: https://github.com/apache/maven/pull/692#issuecomment-1066907104 This looks good even though I'm not that familiar with how providers work, will this lookup on each request (so you get the highest component freshyl on the call) or do it cache it

[jira] [Closed] (MCOMPILER-487) maven-metadata.xml invalid sha1 checksum on Maven Central

2022-03-14 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCOMPILER-487. Resolution: Information Provided > maven-metadata.xml invalid sha1 checksum on Maven Cen

[jira] [Commented] (MCOMPILER-487) maven-metadata.xml invalid sha1 checksum on Maven Central

2022-03-14 Thread Antoine Mottier (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506260#comment-17506260 ] Antoine Mottier commented on MCOMPILER-487: --- I reported the issue on Maven C

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-14 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1066844515 > . If you define the following in the root pom: This works because the aggregator is an implicit parent. -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-build-cache-extension] gnodet commented on pull request #8: Use official maven snapshots

2022-03-14 Thread GitBox
gnodet commented on pull request #8: URL: https://github.com/apache/maven-build-cache-extension/pull/8#issuecomment-1066842988 Blocked by https://github.com/apache/maven/pull/692 and https://github.com/apache/maven/pull/693 -- This is an automated message from the Apache Git Service. To

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-14 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1066841960 I've tried a few things with your example and that led me to understand something I had missed. If you define the following in the root pom: ```

[GitHub] [maven] gnodet closed pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-14 Thread GitBox
gnodet closed pull request #690: URL: https://github.com/apache/maven/pull/690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (MWRAPPER-23) in maven-wrapper, maven user home is not consistent with maven core

2022-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506245#comment-17506245 ] ASF GitHub Bot commented on MWRAPPER-23: gzm55 commented on pull request #28: UR

[GitHub] [maven-wrapper] gzm55 commented on pull request #28: [MWRAPPER-23] Get maven user home (~/.m2) with the same logic with maven

2022-03-14 Thread GitBox
gzm55 commented on pull request #28: URL: https://github.com/apache/maven-wrapper/pull/28#issuecomment-1066821512 `mavenUserHome` is more like a maven directory for [user configuration](https://github.com/apache/maven/blob/maven-3.8.5/maven-embedder/src/main/java/org/apache/maven/cli/MavenC

[jira] [Commented] (MWRAPPER-23) in maven-wrapper, maven user home is not consistent with maven core

2022-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506234#comment-17506234 ] ASF GitHub Bot commented on MWRAPPER-23: jorsol commented on pull request #28: U

[GitHub] [maven-wrapper] jorsol commented on pull request #28: [MWRAPPER-23] Get maven user home (~/.m2) with the same logic with maven

2022-03-14 Thread GitBox
jorsol commented on pull request #28: URL: https://github.com/apache/maven-wrapper/pull/28#issuecomment-1066776123 There is no fixed `~/.m2`, I still don't understand what exactly means "share the same behavior with maven", maven doesn't impose a location for the maven distribution and the

[jira] [Commented] (MWRAPPER-23) in maven-wrapper, maven user home is not consistent with maven core

2022-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506228#comment-17506228 ] ASF GitHub Bot commented on MWRAPPER-23: gzm55 commented on pull request #28: UR

[GitHub] [maven-wrapper] gzm55 commented on pull request #28: [MWRAPPER-23] Get maven user home (~/.m2) with the same logic with maven

2022-03-14 Thread GitBox
gzm55 commented on pull request #28: URL: https://github.com/apache/maven-wrapper/pull/28#issuecomment-1066756233 wrapper should better share the same behavior with maven, avoid unexpected misunderstanding on a maven scope location "maven user home". if this base dir is wrapper specific, i

[jira] [Commented] (MRELEASE-1080) Maven 3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-14 Thread Mirko Klemm (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506227#comment-17506227 ] Mirko Klemm commented on MRELEASE-1080: --- The workaround regarding the plexus-int

[jira] [Commented] (MCOMPILER-487) maven-metadata.xml invalid sha1 checksum on Maven Central

2022-03-14 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506221#comment-17506221 ] Michael Osipov commented on MCOMPILER-487: -- This should be reported with http

[jira] [Commented] (MWRAPPER-23) in maven-wrapper, maven user home is not consistent with maven core

2022-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506218#comment-17506218 ] ASF GitHub Bot commented on MWRAPPER-23: jorsol commented on pull request #28: U

[GitHub] [maven-wrapper] jorsol commented on pull request #28: [MWRAPPER-23] Get maven user home (~/.m2) with the same logic with maven

2022-03-14 Thread GitBox
jorsol commented on pull request #28: URL: https://github.com/apache/maven-wrapper/pull/28#issuecomment-1066733196 Sorry, but I don't understand why it has to be a fixed location. This is actually a useful feature and I fail see why remove it. -- This is an automated message from t

[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #65: Bump apiMaven.version from 3.0 to 3.8.5

2022-03-14 Thread GitBox
dependabot[bot] opened a new pull request #65: URL: https://github.com/apache/maven-artifact-transfer/pull/65 Bumps `apiMaven.version` from 3.0 to 3.8.5. Updates `maven-core` from 3.0 to 3.8.5 Release notes Sourced from https://github.com/apache/maven/releases";>maven-core's re

[jira] [Commented] (MCOMPILER-487) maven-metadata.xml invalid sha1 checksum on Maven Central

2022-03-14 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506193#comment-17506193 ] Slawomir Jaranowski commented on MCOMPILER-487: --- it is something strange

[GitHub] [maven-resolver] caiwei-ebay commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-14 Thread GitBox
caiwei-ebay commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1066675401 > LGTM, but minor: on skipper iface also since 1.8.0? Done. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Created] (MCOMPILER-487) maven-metadata.xml invalid sha1 checksum on Maven Central

2022-03-14 Thread Antoine Mottier (Jira)
Antoine Mottier created MCOMPILER-487: - Summary: maven-metadata.xml invalid sha1 checksum on Maven Central Key: MCOMPILER-487 URL: https://issues.apache.org/jira/browse/MCOMPILER-487 Project: Maven

[GitHub] [maven-resolver] caiwei-ebay commented on a change in pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-14 Thread GitBox
caiwei-ebay commented on a change in pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#discussion_r825803369 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java ## @@ -85,6 +86,21 @@

[GitHub] [maven-resolver] cstamas edited a comment on pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout

2022-03-14 Thread GitBox
cstamas edited a comment on pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#issuecomment-1066616895 IMO, as we still test with `endsWith`, dotless and dotted is important, but for simplicity sake, we'd maybe enforce configuration to use only dotted (dot prefixed)

[GitHub] [maven-resolver] cstamas edited a comment on pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout

2022-03-14 Thread GitBox
cstamas edited a comment on pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#issuecomment-1066616895 IMO, as we still test with `endsWith`, dotless and dotted is important, but for simplicity sake, we'd maybe enforce configuration to use only dotted (dot prefixed)

[jira] [Commented] (MWRAPPER-59) Inline MavenWrapperDownloader.java into mvnw

2022-03-14 Thread Jira
[ https://issues.apache.org/jira/browse/MWRAPPER-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506138#comment-17506138 ] Jorge Solórzano commented on MWRAPPER-59: - I'm not sure if it's a good idea to i

[GitHub] [maven-resolver] cstamas commented on pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout

2022-03-14 Thread GitBox
cstamas commented on pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#issuecomment-1066616895 IMO, as we still test with `endsWith`, dotless and dotted is important, but for simplicity sake, we'd maybe enforce configuration to use only dotted (dot prefixed) input.

[GitHub] [maven-resolver] cstamas commented on a change in pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-14 Thread GitBox
cstamas commented on a change in pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#discussion_r825790414 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java ## @@ -85,6 +86,21 @@

[GitHub] [maven] slawekjaranowski commented on pull request #285: [MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin

2022-03-14 Thread GitBox
slawekjaranowski commented on pull request #285: URL: https://github.com/apache/maven/pull/285#issuecomment-1066582524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [maven-resolver] caiwei-ebay commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-14 Thread GitBox
caiwei-ebay commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1066572661 > This look very promising. Please document this parameter in the documentation page. Please check https://github.com/apache/maven-resolver/pull/158/commits/ada

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-14 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1066554536 > Well, I'd like to be sure about that. All the use cases I've seen so far rather indicate extensions are global to the build. Which ones? Just for the sake of leaving the fie

[jira] [Commented] (MPOM-303) Rename property maven.plugin.tools.version to mavenPluginToolsVersion

2022-03-14 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPOM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506080#comment-17506080 ] Michael Osipov commented on MPOM-303: - Your proposal would contradict this scheme as we

[jira] [Commented] (SUREFIRE-2037) Allow for surefire-junit-platform's TestMethodFilter to support custom TestSources

2022-03-14 Thread Jira
[ https://issues.apache.org/jira/browse/SUREFIRE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506056#comment-17506056 ] Krzysztof Sierszeń commented on SUREFIRE-2037: -- [~tibordigana] Please see

[jira] [Updated] (MPOM-302) Rename property surefire.version to surefireVersion

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MPOM-302: --- Description: {{surefire.version}} property was introduced in MPOM-108 released first in ASF parent 18 o

[jira] [Updated] (MPOM-303) Rename property maven.plugin.tools.version to mavenPluginToolsVersion

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MPOM-303: --- Description: {{maven.plugin.tools.version}} was introduced in ASF parent 25 on 2022-02-20 (one week ag

[jira] [Commented] (MPOM-302) Rename property surefire.version to surefireVersion

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506048#comment-17506048 ] Herve Boutemy commented on MPOM-302: after discussion with [~michaelo], existing {{sure

[jira] [Comment Edited] (MPOM-303) Rename property maven.plugin.tools.version to mavenPluginToolsVersion

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506046#comment-17506046 ] Herve Boutemy edited comment on MPOM-303 at 3/14/22, 7:53 AM: --

[jira] [Commented] (MPOM-303) Rename property maven.plugin.tools.version to mavenPluginToolsVersion

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506046#comment-17506046 ] Herve Boutemy commented on MPOM-303: I wrote in the description the issues found in {{m

[jira] [Updated] (MPOM-303) Rename property maven.plugin.tools.version to mavenPluginToolsVersion

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MPOM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MPOM-303: --- Description: {{maven.plugin.tools.version}} was introduced in ASF parent 25 https://github.com/apache/

[jira] [Commented] (MWRAPPER-60) move maven-wrapper.jar into ~/.m2/wrapper/dists dir

2022-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506043#comment-17506043 ] ASF GitHub Bot commented on MWRAPPER-60: gzm55 opened a new pull request #32: UR

[GitHub] [maven-wrapper] gzm55 opened a new pull request #32: MWRAPPER-60 place maven-wrapper.jar into ~/.m2/wrapper/dists

2022-03-14 Thread GitBox
gzm55 opened a new pull request #32: URL: https://github.com/apache/maven-wrapper/pull/32 1. place maven-wrapper.jar at `~/.m2/wrapper/dists/maven-wrapper//` dir 2. now, `mvnw` script is updated and tested 3. remove undocumented and unused variable MAVEN_BASEDIR, like maven 4

[jira] [Commented] (MNG-7430) mark MojoExecutionException as deprecated

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506037#comment-17506037 ] Herve Boutemy commented on MNG-7430: yes, particularly once the message "[INFO] BUILD E

[jira] [Comment Edited] (MNG-7430) mark MojoExecutionException as deprecated

2022-03-14 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506037#comment-17506037 ] Herve Boutemy edited comment on MNG-7430 at 3/14/22, 7:36 AM: --

[GitHub] [maven-resolver] michael-o commented on pull request #154: [MRESOLVER-241] Resolver checksum calculation should be driven by layout

2022-03-14 Thread GitBox
michael-o commented on pull request #154: URL: https://github.com/apache/maven-resolver/pull/154#issuecomment-1066450554 > What happended to `foo`,`.asc` dot and dotless? Only this one is left. I will put this into testing meanwhile. -- This is an automated message from the Apache

[GitHub] [maven-resolver] michael-o edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-14 Thread GitBox
michael-o edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1066443723 I'll leave Ivan one more week to respond since he's likely having a hard time. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [maven-resolver] michael-o commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-14 Thread GitBox
michael-o commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1066443723 This look very promising. Please document this parameter in the documentation page. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [maven-resolver] michael-o commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-14 Thread GitBox
michael-o commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1066442930 This look very promising. Please document this parameter in the documentation page. -- This is an automated message from the Apache Git Service. To respond to the mess