[ 
https://issues.apache.org/jira/browse/MPOM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506636#comment-17506636
 ] 

Herve Boutemy commented on MPOM-303:
------------------------------------

notice that if we are trying to define a global convention on such version 
properties, and ignore a little bit what we have currently inherited from past 
work done in ASF and Maven parent POMs

there is one convention that I find quite clear to use, like done for example 
in 
https://github.com/Zlika/reproducible-build-maven-plugin/blob/master/pom.xml#L67
it is {{$artifactId.version}}

then it gives {{maven-surefire-plugin.version}}, {{doxia.version}}, etc...

I don't know if we want to define such a global convention as part of this 
issue, but at least, the idea is now written

> Rename property maven.plugin.tools.version to mavenPluginToolsVersion
> ---------------------------------------------------------------------
>
>                 Key: MPOM-303
>                 URL: https://issues.apache.org/jira/browse/MPOM-303
>             Project: Maven POMs
>          Issue Type: Task
>          Components: asf
>    Affects Versions: ASF-25
>            Reporter: Slawomir Jaranowski
>            Priority: Major
>             Fix For: ASF-26
>
>
> {{maven.plugin.tools.version}} was introduced in ASF parent 25 on 2022-02-20 
> (one week ago) 
> https://github.com/apache/maven-apache-parent/commit/5a878dcdc00439cf03d383096c62e9003b503bfe
> having a property starting with {{maven.}} is not a good practice, because 
> this prefix is used by Maven itself: 
> https://maven.apache.org/ref/3.8.5/maven-model-builder/#model-interpolation
> and {{plugin.tools}} should be more {{plugin-tools}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to