[
https://issues.apache.org/jira/browse/MWRAPPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506332#comment-17506332
]
ASF GitHub Bot commented on MWRAPPER-23:
----------------------------------------
jorsol commented on pull request #28:
URL: https://github.com/apache/maven-wrapper/pull/28#issuecomment-1067038041
> mavenUserHome is more like a maven directory for [user
configuration](https://github.com/apache/maven/blob/maven-3.8.5/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L133),
and expected to work as maven.
It's not only for user configuration, it's also used for `maven.repo.local`
(the repository on the local machine), that BTW can also be configured. By
removing this you are making it fixed into `~/.m2` and that already contradicts
your perception of user configuration.
The "naming" of `maven.user.home` might or might not be correct, that could
be debated, it was borrowed from
[gradle](https://docs.gradle.org/current/userguide/directory_layout.html#dir:gradle_user_home)
and the previous wrapper was already using it.
I honestly don't mind if it's renamed to something like
`maven.distro.basedir`, and it should be properly documented, but just removing
this without replacement doesn't sounds like a good plan.
Anyway, the final word should come from a Maven maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> in maven-wrapper, maven user home is not consistent with maven core
> -------------------------------------------------------------------
>
> Key: MWRAPPER-23
> URL: https://issues.apache.org/jira/browse/MWRAPPER-23
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Jar
> Reporter: James Z.M. Gao
> Assignee: Robert Scholte
> Priority: Minor
>
> New maven wrapper guesses the maven user home location via system props,
> system envs
> and at last the default location (~/.m2). This guessing order is the
> convention of the gradle wrapper.
> For maven, user home has a fixed location, i.e. ~/.m2, described
> [here|https://maven.apache.org/settings.html#Settings_Details]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
