[ 
https://issues.apache.org/jira/browse/MPOM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506046#comment-17506046
 ] 

Herve Boutemy edited comment on MPOM-303 at 3/14/22, 7:53 AM:
--------------------------------------------------------------

I wrote in the description the issues found in {{maven.plugin.tools.version}}

for consistency with {{surefire.version}} (that we should not change if we 
don't have strong problems with it: let's discuss it in MPOM-302), I'd be more 
in favor of {{plugin-tools.version}}
Which is IMHO easier to read than {{mavenPluginToolsVersion}}

[~sjaranowski][~michaelo] WDYT?


was (Author: hboutemy):
I wrote in the description the issues found in {{maven.plugin.tools.version}}

for consistency with {{surefire.version}} (that we should not change if we 
don't have strong problems with it: let's discuss it in MPOM-302), I'd be more 
in favor of {{plugin-tools.version}}

> Rename property maven.plugin.tools.version to mavenPluginToolsVersion
> ---------------------------------------------------------------------
>
>                 Key: MPOM-303
>                 URL: https://issues.apache.org/jira/browse/MPOM-303
>             Project: Maven POMs
>          Issue Type: Task
>          Components: asf
>    Affects Versions: ASF-25
>            Reporter: Slawomir Jaranowski
>            Priority: Major
>             Fix For: ASF-26
>
>
> {{maven.plugin.tools.version}} was introduced in ASF parent 25 
> https://github.com/apache/maven-apache-parent/commit/5a878dcdc00439cf03d383096c62e9003b503bfe
> having a property starting with {{maven.}} is not a good practice, because 
> this prefix is used by Maven itself: 
> https://maven.apache.org/ref/3.8.5/maven-model-builder/#model-interpolation
> and {{plugin.tools}} should be more {{plugin-tools}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to